From: Paolo Bonzini <pbonzini@redhat.com>
To: "Richard Henderson" <rth@twiddle.net>,
"Pranith Kumar" <bobby.prani@gmail.com>,
"Emilio G. Cota" <cota@braap.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Sergey Fedorov" <sergey.fedorov@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast
Date: Mon, 8 Aug 2016 12:02:36 +0200 [thread overview]
Message-ID: <1ced2a30-ef21-c14a-bd76-780fe2d20f73@redhat.com> (raw)
In-Reply-To: <080c7421-c46d-f98a-5a38-7ad6eaf6bd35@twiddle.net>
On 08/08/2016 12:00, Richard Henderson wrote:
> On 08/08/2016 03:25 PM, Paolo Bonzini wrote:
>> +
>> __builtin_choose_expr( \
>> + __builtin_types_compatible_p(typeof(expr), const char)
>> || \
>> + __builtin_types_compatible_p(typeof(expr),
>> char), \
>> +
>> (char)1, \
>
> Better as signed char, since bare char could be either signed or unsigned.
It's also better to add a volatile case.
Paolo
next prev parent reply other threads:[~2016-08-08 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 1:41 [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast Pranith Kumar
2016-08-08 9:05 ` Paolo Bonzini
2016-08-08 9:27 ` Paolo Bonzini
2016-08-08 9:55 ` Paolo Bonzini
2016-08-08 10:00 ` Richard Henderson
2016-08-08 10:02 ` Paolo Bonzini [this message]
2016-08-08 10:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ced2a30-ef21-c14a-bd76-780fe2d20f73@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=bobby.prani@gmail.com \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sergey.fedorov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).