From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CCA2C87FD3 for ; Fri, 8 Aug 2025 16:08:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ukPdc-0000vZ-RD; Fri, 08 Aug 2025 12:08:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukPdV-0000sD-3T for qemu-devel@nongnu.org; Fri, 08 Aug 2025 12:08:06 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ukPdT-0008Vs-E2 for qemu-devel@nongnu.org; Fri, 08 Aug 2025 12:08:04 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3b8db5e9b35so1224194f8f.1 for ; Fri, 08 Aug 2025 09:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754669281; x=1755274081; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=2UmMFBDfKJsvqp9hiPE1ZCZpOSiKT0wAMQRCT46+kmQ=; b=FFaQCp44V8cT1BQB8RlfuMgian1oOjP3f37NQkQbJyyXCZlu5IE2dcXTtDjKjryFfY 1FyD6VPT8JIkXYzF91QvjjCBlISvYYHgwaNbad0FrfDaJ1GEra1d0pR2yr9Qw+OUVcnp tdV2677zBTOfQt5rCErHWNJmDXY6L153aLTz88CpAasd0UAzNXcvdxO5YxzG4BYxt8tU WYCHrSOGFCj+FLX9EFZqDBYrxUXm8ticPapMgf4ZT1lDjw2Dr024NLS/lBSUoAgMtt29 yQ/JCcHtEczDZKHvOMn4lKKNiv1vNOxBBxxfGo6IwQg+340bbuRH0we4/8uj1aGvNF0J 15jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754669281; x=1755274081; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2UmMFBDfKJsvqp9hiPE1ZCZpOSiKT0wAMQRCT46+kmQ=; b=aiPixCQsoA91dyykS4b/mfcCGirG7le1ndRfA8WwMU2IBFFbeyA6lWUP+KQsM8mTTQ V+wLXOLbMGXYPdbU2HspIy8UbX+x2Ua0ngl0Tte73HWk4+lWS7CusSqWap/roMp9lmz3 +8HyLOhS+UQ87QlT+tOEijiSnv90tM8Q3GLzZfq1xalwF075W+kobtPbW1Qy4NYC9jZb GaOjx59wX0YZ/A48Zec7bj/i24PG+nRWTvOESbVn6IHohRbj7u33QXXXcQGtaKS5oQEg oFf/9+Ear3zbXgbkiCDmffIKPxM8sCiVKRiEWia9LxSro54YYx/6TRmDDm/DEECwAreJ rRDA== X-Forwarded-Encrypted: i=1; AJvYcCUwIs8hT/Zo+ESe4aylCLvW8YmK0Ssz0XsOat/DpMr+QbGAqws+63vu7Rmc0CI2TD5U0PR/2f+vp9Ll@nongnu.org X-Gm-Message-State: AOJu0YykTxvrGuwGfIMza9QV7eGLG4WYEAmyJzedBkRXpcxI5ct9Uzh8 VgVKbPL5xNNKm7230jGPiy9sqhwsIrncU6/Zv6RUc1lVuyvunq0OkSLofzPJ3X2gliU= X-Gm-Gg: ASbGncsi3411x99LPFfyhLf0L0SPJb7Re2DeND88/Jyd27HSX7v1Ovwx/lmQCHbm231 89CICYJIudlPKYftOk4N/Tm/O7FEiYd3krCneSK9+p+23dBPQh94fXBbJkoGmImRdPJWicMpexc 32QUWYI4hkzWeb95V3h4xUT9IFoq7HCS2jymcWHp4NKONsUc1prS3rfBmtbuCoczDs1XnOvKerr PJmlC15VUn5jljUPO6QoBrkr6ZugUvazLnCoqwt/gLNWYXcbFSBmwJGHvLRH6dJYr9l2mZdCAVJ guLB862N8HHn4OD/XsBAxgjAMJQbYFPJmOKa8QPvvHHGI24v/Mlava8xK+YtNjRfuYxonAbf/Id ERoe6ei4G42mkK/8p9SJaVlRhmdO7FuPld59q+/ej5PwJwfiryQ74IYRoY1jXkdTn0Q== X-Google-Smtp-Source: AGHT+IFIiTSNOvYDxK3HFyvNSfBZE3peRraLmP+wlq8P/jPHHpJNAdFtogaR9uH8TWOaJm0FGdF6pw== X-Received: by 2002:a05:6000:3108:b0:3a3:7ba5:93a5 with SMTP id ffacd0b85a97d-3b900b37bddmr3146456f8f.26.1754669280923; Fri, 08 Aug 2025 09:08:00 -0700 (PDT) Received: from [192.168.69.210] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45923c34af8sm242737735e9.24.2025.08.08.09.07.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Aug 2025 09:08:00 -0700 (PDT) Message-ID: <1cf4f7e5-c9d2-49fd-98db-fd8d05fd241f@linaro.org> Date: Fri, 8 Aug 2025 18:07:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 08/14] hw/misc: Add RISC-V CMGCR device implementation From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= To: Djordje Todorovic , "qemu-devel@nongnu.org" Cc: "qemu-riscv@nongnu.org" , "cfu@mips.com" , "mst@redhat.com" , "marcel.apfelbaum@gmail.com" , "dbarboza@ventanamicro.com" References: <20250717093833.402237-1-djordje.todorovic@htecgroup.com> <20250717093833.402237-9-djordje.todorovic@htecgroup.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/8/25 18:00, Philippe Mathieu-Daudé wrote: > On 17/7/25 11:38, Djordje Todorovic wrote: >> Add RISC-V implementation of the Coherent Manager Global Control >> Register (CMGCR) device. It is based on the existing MIPS CMGCR >> implementation but adapted for RISC-V systems. >> >> The CMGCR device provides global system control for multi-core >> configurations in RISC-V systems. >> >> This is needed for the MIPS BOSTON AIA board. >> >> Signed-off-by: Chao-ying Fu >> Signed-off-by: Djordje Todorovic >> --- >>   hw/misc/Kconfig               |  10 ++ >>   hw/misc/meson.build           |   2 + >>   hw/misc/riscv_cmgcr.c         | 234 ++++++++++++++++++++++++++++++++++ >>   include/hw/misc/riscv_cmgcr.h |  49 +++++++ >>   4 files changed, 295 insertions(+) >>   create mode 100644 hw/misc/riscv_cmgcr.c >>   create mode 100644 include/hw/misc/riscv_cmgcr.h > > >> +static void riscv_gcr_realize(DeviceState *dev, Error **errp) >> +{ >> +    RISCVGCRState *s = RISCV_GCR(dev); > > Please report an error for invalid num_vps values (0 or >MAX). Per the next patch: #define VPS_MAX 64 Is it possible to have a config with 7, 24 or 35 vps? > >> + >> +    /* Create local set of registers for each VP */ >> +    s->vps = g_new(RISCVGCRVPState, s->num_vps); >> +}