qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Zihan Yang <whois.zihan.yang@gmail.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [RFC v4 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST
Date: Thu, 9 Aug 2018 11:48:56 -0500	[thread overview]
Message-ID: <1cf87364-5a10-bf64-dbfa-981456ecf365@redhat.com> (raw)
In-Reply-To: <CAKwiv-j16RoLy0oXUa+NY2eMW8s12E2+vFjxy8Y4J_bOM=Sm+A@mail.gmail.com>

On 08/09/2018 11:39 AM, Zihan Yang wrote:
> Eric Blake <eblake@redhat.com> 于2018年8月9日周四 下午9:23写道:
>>
>> On 08/09/2018 01:33 AM, Zihan Yang wrote:
>>> The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default,
>>> change it to a new type TYPE_PXB_PCIE_HOST to better utilize ECAM of PCIe
>>
>> meta-comment:
>>
>> Your messages came through unthreaded (seven separate threads), rather
>> than properly marked 'References:' and 'In-reply-to:' to the 0/6 cover
>> letter <1533796115-15837-1-git-send-email-whois.zihan.yang@gmail.com>,
>> which makes it a bit harder to keep track of the conversation when
>> viewing mails sorted by threads with most recent activity.
> 
> My mistake, I manually added the cc of cover letter, which is not
> covered by cccmd,
> but I didn't add In-reply-to of remaining mails. I will directly add
> an "cc: " field in cover
> letter and send them all in later patches to avoid breaking them up.
> 
> As for this patch set, should I resend them or save it to v5, which I
> will try working out
> this weekend?

At this point, it's probably still worth waiting for any comments on v4, 
so that v5 can fix those issues.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-08-09 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  6:33 [Qemu-devel] [RFC v4 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST Zihan Yang
2018-08-09 13:23 ` Eric Blake
2018-08-09 16:39   ` Zihan Yang
2018-08-09 16:48     ` Eric Blake [this message]
2018-08-17 17:14 ` Marcel Apfelbaum
2018-08-19  1:51   ` Zihan Yang
2018-08-25 20:08     ` Marcel Apfelbaum
2018-08-27  2:18       ` Zihan Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cf87364-5a10-bf64-dbfa-981456ecf365@redhat.com \
    --to=eblake@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=whois.zihan.yang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).