From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 03/11] target/mips: Create report_fault for semihosting
Date: Fri, 10 Jun 2022 17:05:57 +0200 [thread overview]
Message-ID: <1cfdf6db-791b-1d4c-29ac-4248a917e273@amsat.org> (raw)
In-Reply-To: <20220608051945.802339-4-richard.henderson@linaro.org>
Hi Richard,
On 8/6/22 07:19, Richard Henderson wrote:
> The UHI specification does not have an EFAULT value,
> and further specifies that "undefined UHI operations
> should not return control to the target".
>
> So, log the error and abort.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/mips/tcg/sysemu/mips-semi.c | 33 ++++++++++++++----------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/target/mips/tcg/sysemu/mips-semi.c b/target/mips/tcg/sysemu/mips-semi.c
> index 2a039baf4c..33221444e1 100644
> --- a/target/mips/tcg/sysemu/mips-semi.c
> +++ b/target/mips/tcg/sysemu/mips-semi.c
> @@ -114,6 +114,13 @@ enum UHIErrno {
> UHI_EXDEV = 18,
> };
>
> +static void report_fault(CPUMIPSState *env)
> +{
> + int op = env->active_tc.gpr[25];
> + error_report("Fault during UHI operation %d", op);
> + abort();
This is a guest error, no need to debug QEMU internals...
Can we simply exit(1) instead?
next prev parent reply other threads:[~2022-06-10 15:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 5:19 [PATCH v4 00/11] target/mips: semihosting cleanup Richard Henderson
2022-06-08 5:19 ` [PATCH v4 01/11] target/mips: Use an exception for semihosting Richard Henderson
2022-06-10 15:07 ` Philippe Mathieu-Daudé via
2022-06-08 5:19 ` [PATCH v4 02/11] target/mips: Add UHI errno values Richard Henderson
2022-06-10 15:07 ` Philippe Mathieu-Daudé via
2022-06-08 5:19 ` [PATCH v4 03/11] target/mips: Create report_fault for semihosting Richard Henderson
2022-06-10 15:05 ` Philippe Mathieu-Daudé via [this message]
2022-06-11 15:53 ` Richard Henderson
2022-06-08 5:19 ` [PATCH v4 04/11] target/mips: Drop link syscall from semihosting Richard Henderson
2022-06-08 5:19 ` [PATCH v4 05/11] target/mips: Drop pread and pwrite syscalls " Richard Henderson
2022-06-10 15:07 ` Philippe Mathieu-Daudé via
2022-06-08 5:19 ` [PATCH v4 06/11] target/mips: Use semihosting/syscalls.h Richard Henderson
2022-06-08 5:19 ` [PATCH v4 07/11] target/mips: Avoid qemu_semihosting_log_out for UHI_plog Richard Henderson
2022-06-08 5:19 ` [PATCH v4 08/11] target/mips: Use error_report for UHI_assert Richard Henderson
2022-06-10 15:10 ` Philippe Mathieu-Daudé via
2022-06-08 5:19 ` [PATCH v4 09/11] semihosting: Remove qemu_semihosting_log_out Richard Henderson
2022-06-10 15:11 ` Philippe Mathieu-Daudé via
2022-06-08 5:19 ` [PATCH v4 10/11] target/mips: Simplify UHI_argnlen and UHI_argn Richard Henderson
2022-06-08 5:19 ` [PATCH v4 11/11] target/mips: Remove GET_TARGET_STRING and FREE_TARGET_STRING Richard Henderson
2022-06-10 15:12 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cfdf6db-791b-1d4c-29ac-4248a917e273@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=f4bug@amsat.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).