From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Eugenio Perez Martin <eperezma@redhat.com>,
German Maglione <gmaglione@redhat.com>,
Liu Jiang <gerry@linux.alibaba.com>,
Sergio Lopez Pascual <slp@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>
Subject: Re: [PATCH 6/7] vhost-user: allow "vhost_set_vring" to wait for a reply
Date: Tue, 29 Aug 2023 00:49:54 +0200 [thread overview]
Message-ID: <1d0c927d-3b75-a307-cf05-a4236c7decf5@linaro.org> (raw)
In-Reply-To: <20230827182937.146450-7-lersek@redhat.com>
On 27/8/23 20:29, Laszlo Ersek wrote:
> The "vhost_set_vring" function already centralizes the common parts of
> "vhost_user_set_vring_num", "vhost_user_set_vring_base" and
> "vhost_user_set_vring_enable". We'll want to allow some of those callers
> to wait for a reply.
>
> Therefore, rebase "vhost_set_vring" from just "vhost_user_write" to
> "vhost_user_write_msg", exposing the "wait_for_reply" parameter.
>
> This is purely refactoring -- there is no observable change. That's
> because:
>
> - all three callers pass in "false" for "wait_for_reply", which disables
> all logic in "vhost_user_write_msg" except the call to
> "vhost_user_write";
>
> - the fds=NULL and fd_num=0 arguments of the original "vhost_user_write"
> call inside "vhost_set_vring" are hard-coded within
> "vhost_user_write_msg".
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:vhost)
> Cc: Eugenio Perez Martin <eperezma@redhat.com>
> Cc: German Maglione <gmaglione@redhat.com>
> Cc: Liu Jiang <gerry@linux.alibaba.com>
> Cc: Sergio Lopez Pascual <slp@redhat.com>
> Cc: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> hw/virtio/vhost-user.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-28 22:50 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 18:29 [PATCH 0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Laszlo Ersek
2023-08-27 18:29 ` [PATCH 1/7] vhost-user: strip superfluous whitespace Laszlo Ersek
2023-08-30 8:26 ` Stefano Garzarella
2023-08-30 15:04 ` Philippe Mathieu-Daudé
2023-08-27 18:29 ` [PATCH 2/7] vhost-user: tighten "reply_supported" scope in "set_vring_addr" Laszlo Ersek
2023-08-30 8:27 ` Stefano Garzarella
2023-08-30 15:04 ` Philippe Mathieu-Daudé
2023-08-27 18:29 ` [PATCH 3/7] vhost-user: factor out "vhost_user_write_msg" Laszlo Ersek
2023-08-28 22:46 ` Philippe Mathieu-Daudé
2023-08-30 8:31 ` Stefano Garzarella
2023-08-30 9:14 ` Laszlo Ersek
2023-08-30 9:54 ` Laszlo Ersek
2023-08-27 18:29 ` [PATCH 4/7] vhost-user: flatten "enforce_reply" into "vhost_user_write_msg" Laszlo Ersek
2023-08-28 22:47 ` Philippe Mathieu-Daudé
2023-08-30 8:31 ` Stefano Garzarella
2023-08-27 18:29 ` [PATCH 5/7] vhost-user: hoist "write_msg", "get_features", "get_u64" Laszlo Ersek
2023-08-30 8:32 ` Stefano Garzarella
2023-08-30 15:04 ` Philippe Mathieu-Daudé
2023-08-27 18:29 ` [PATCH 6/7] vhost-user: allow "vhost_set_vring" to wait for a reply Laszlo Ersek
2023-08-28 22:49 ` Philippe Mathieu-Daudé [this message]
2023-08-30 8:32 ` Stefano Garzarella
2023-08-27 18:29 ` [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Laszlo Ersek
2023-08-30 8:39 ` Stefano Garzarella
2023-08-30 9:26 ` Laszlo Ersek
2023-08-30 14:24 ` Stefano Garzarella
2023-08-30 8:41 ` Laszlo Ersek
2023-08-30 8:59 ` Laszlo Ersek
2023-08-30 9:04 ` Laszlo Ersek
2023-08-30 12:10 ` Stefan Hajnoczi
2023-08-30 13:30 ` Laszlo Ersek
2023-08-30 15:37 ` Stefan Hajnoczi
2023-09-05 6:30 ` Laszlo Ersek
2023-09-25 15:31 ` Laszlo Ersek
2023-10-01 19:24 ` Michael S. Tsirkin
2023-10-01 19:25 ` Michael S. Tsirkin
2023-10-02 1:56 ` Laszlo Ersek
2023-10-02 6:57 ` Michael S. Tsirkin
2023-10-02 14:02 ` Laszlo Ersek
2023-10-02 6:49 ` Michael S. Tsirkin
2023-10-02 21:12 ` Stefan Hajnoczi
2023-10-02 21:13 ` Stefan Hajnoczi
2023-10-03 12:26 ` Michael S. Tsirkin
2023-10-03 13:08 ` Stefan Hajnoczi
2023-10-03 13:23 ` Laszlo Ersek
2023-10-03 14:25 ` Michael S. Tsirkin
2023-10-03 14:28 ` Laszlo Ersek
2023-10-03 14:40 ` Michael S. Tsirkin
2023-10-03 15:45 ` Stefan Hajnoczi
2023-10-02 22:36 ` Michael S. Tsirkin
2023-10-03 0:17 ` Stefan Hajnoczi
2023-10-03 14:28 ` Michael S. Tsirkin
2023-10-03 14:41 ` Michael S. Tsirkin
2023-10-03 15:55 ` Stefan Hajnoczi
2023-10-04 10:15 ` Laszlo Ersek
2023-10-04 16:30 ` Michael S. Tsirkin
2023-10-04 10:17 ` Laszlo Ersek
2023-08-30 8:48 ` [PATCH 0/7] " Stefano Garzarella
2023-08-30 9:32 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0c927d-3b75-a307-cf05-a4236c7decf5@linaro.org \
--to=philmd@linaro.org \
--cc=eperezma@redhat.com \
--cc=gerry@linux.alibaba.com \
--cc=gmaglione@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).