From: Richard Henderson <richard.henderson@linaro.org>
To: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
kvm@vger.kernel.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v3 03/29] include/exec/cpu-all: move compile time check for CPUArchState to cpu-target.c
Date: Wed, 2 Apr 2025 13:06:36 -0700 [thread overview]
Message-ID: <1d13c66a-e932-48c4-801c-9b14890679c5@linaro.org> (raw)
In-Reply-To: <319fd6a2-93c1-42ec-866b-86e4d01b4b39@linaro.org>
On 4/2/25 08:25, Pierrick Bouvier wrote:
> On 4/1/25 20:31, Philippe Mathieu-Daudé wrote:
>> With "cpu.h" include:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>
>
> I can't reproduce this error.
> With this series, cpu.h is pulled transitively from "accel/accel-cpu-target.h". Ideally,
> it would be better to add it explicitely yes.
>
> @Richard, could you please amend this commit on tcg-next and add a direct include to cpu.h?
Done.
r~
next prev parent reply other threads:[~2025-04-02 20:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 4:58 [PATCH v3 00/29] single-binary: start make hw/arm/ common Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 01/29] exec/cpu-all: extract tlb flags defines to exec/tlb-flags.h Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 02/29] exec/cpu-all: move cpu_copy to linux-user/qemu.h Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 03/29] include/exec/cpu-all: move compile time check for CPUArchState to cpu-target.c Pierrick Bouvier
2025-04-02 3:31 ` Philippe Mathieu-Daudé
2025-04-02 15:25 ` Pierrick Bouvier
2025-04-02 20:06 ` Richard Henderson [this message]
2025-04-03 16:18 ` Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 04/29] exec/cpu-all: remove system/memory include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 05/29] exec/cpu-all: remove exec/page-protection include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 06/29] exec/cpu-all: remove tswap include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 07/29] exec/cpu-all: remove exec/cpu-interrupt include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 08/29] exec/cpu-all: remove exec/cpu-defs include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 09/29] exec/cpu-all: remove exec/target_page include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 10/29] exec/cpu-all: remove hw/core/cpu.h include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 11/29] accel/tcg: fix missing includes for TCG_GUEST_DEFAULT_MO Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 12/29] accel/tcg: fix missing includes for TARGET_HAS_PRECISE_SMC Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 13/29] exec/cpu-all: remove cpu include Pierrick Bouvier
2025-03-25 4:58 ` [PATCH v3 14/29] exec/cpu-all: transfer exec/cpu-common include to cpu.h headers Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 15/29] exec/cpu-all: remove this header Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 16/29] exec/target_page: runtime defintion for TARGET_PAGE_BITS_MIN Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 17/29] accel/kvm: move KVM_HAVE_MCE_INJECTION define to kvm-all.c Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 18/29] exec/poison: KVM_HAVE_MCE_INJECTION can now be poisoned Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 19/29] target/arm/cpu: always define kvm related registers Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 20/29] target/arm/cpu: flags2 is always uint64_t Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 21/29] target/arm/cpu: define same set of registers for aarch32 and aarch64 Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 22/29] target/arm/cpu: remove inline stubs for aarch32 emulation Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 23/29] meson: add common hw files Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 24/29] hw/arm/boot: make compilation unit hw common Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 25/29] hw/arm/armv7m: prepare compilation unit to be common Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 26/29] hw/arm/digic_boards: " Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 27/29] hw/arm/xlnx-zynqmp: " Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 28/29] hw/arm/xlnx-versal: " Pierrick Bouvier
2025-03-25 4:59 ` [PATCH v3 29/29] hw/arm: make most of the compilation units common Pierrick Bouvier
2025-03-25 5:02 ` [PATCH v3 00/29] single-binary: start make hw/arm/ common Pierrick Bouvier
2025-03-31 22:38 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d13c66a-e932-48c4-801c-9b14890679c5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).