From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cao Jiaxi <driver1998@foxmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64
Date: Fri, 3 May 2019 11:06:15 +0200 [thread overview]
Message-ID: <1d1f8690-518b-dd06-c7e1-b1d88b2d1f5d@redhat.com> (raw)
In-Reply-To: <20190503002930.9991-1-driver1998@foxmail.com>
On 5/3/19 2:29 AM, Cao Jiaxi wrote:
> Windows ARM64 uses LLP64 model, which breaks current assumptions.
>
> Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
> ---
> util/cacheinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/cacheinfo.c b/util/cacheinfo.c
> index 3cd080b83d..eebe1ce9c5 100644
> --- a/util/cacheinfo.c
> +++ b/util/cacheinfo.c
> @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize)
> static void arch_cache_info(int *isize, int *dsize)
> {
> if (*isize == 0 || *dsize == 0) {
> - unsigned long ctr;
> + uint64_t ctr;
>
> /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
> but (at least under Linux) these are marked protected by the
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-05-03 9:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190503002258.9799-1-driver1998@foxmail.com>
2019-05-03 0:23 ` [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets Cao Jiaxi
2019-05-03 0:23 ` Cao Jiaxi
2019-05-03 0:25 ` [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion Cao Jiaxi
2019-05-03 0:25 ` Cao Jiaxi
2019-05-03 9:03 ` Philippe Mathieu-Daudé
2019-05-03 9:03 ` Philippe Mathieu-Daudé
2019-05-03 0:29 ` [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64 Cao Jiaxi
2019-05-03 0:29 ` Cao Jiaxi
2019-05-03 9:06 ` Philippe Mathieu-Daudé [this message]
2019-05-03 9:06 ` Philippe Mathieu-Daudé
2019-05-03 0:31 ` [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats Cao Jiaxi
2019-05-03 0:31 ` Cao Jiaxi
2019-05-03 10:13 ` Philippe Mathieu-Daudé
2019-05-03 10:13 ` Philippe Mathieu-Daudé
2019-05-03 0:22 [Qemu-devel] [PATCH v3 0/4] Initial Windows on ARM (AArch64 64-Bit) host support Cao Jiaxi
2019-05-03 0:37 ` [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64 Cao Jiaxi
2019-05-03 0:37 ` Cao Jiaxi
2019-05-03 3:31 ` Richard Henderson
2019-05-03 3:31 ` Richard Henderson
2019-05-03 5:10 ` Thomas Huth
2019-05-03 5:10 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1f8690-518b-dd06-c7e1-b1d88b2d1f5d@redhat.com \
--to=philmd@redhat.com \
--cc=driver1998@foxmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).