Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat

[Bastian Koppelmann <kbastian@mail.uni-paderborn.de>]

Hi Emilio,

On 03/27/2018 07:33 AM, Emilio G. Cota wrote:
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg05908.html
> 
[...]
> 
> Perf numbers are in the last patch. They are a little different than
> last week; I cannot replicate last week's performance (even with
> the very same binaries; might have to reboot the machine I'm using
> soon), but as of today v2 is certainly faster than v1 (e.g. 5% faster
> for nbench-fp).
> 
> I have checked all checkpatch warnings; they're all false positives.
> 
> You can fetch the series from:
>   https://github.com/cota/qemu/tree/hardfloat-v2

When I try to build your tree with gcc version 7.3.1 20180312 (GCC), I get:

  CC      tricore-softmmu/fpu/softfloat.o
/home/kbastian/coding/upstream-qemu/qemu-fpu/fpu/softfloat.c:417:19:
error: conflicting types for ‘canonicalize’
 static FloatParts canonicalize(FloatParts part, const FloatFmt *parm,
                   ^~~~~~~~~~~~
In file included from /usr/include/features.h:423:0,
                 from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/math.h:27,
                 from
/home/kbastian/coding/upstream-qemu/qemu-fpu/fpu/softfloat.c:85:
/usr/include/bits/mathcalls.h:385:1: note: previous declaration of
‘canonicalize’ was here
 __MATHDECL_1 (int, canonicalize,, (_Mdouble_ *__cx, const _Mdouble_ *__x));

Cheers,
Bastian