Re: [PATCH v2 07/21] target/i386: allow access_ptr to force slow path on failed probe

[Richard Henderson <richard.henderson@linaro.org>]

On 8/14/24 06:23, Alex Bennée wrote:
> When we are using TCG plugin memory callbacks probe_access_internal
> will return TLB_MMIO to force the slow path for memory access. This
> results in probe_access returning NULL but the x86 access_ptr function
> happily accepts an empty haddr resulting in segfault hilarity.
> 
> Check for an empty haddr to prevent the segfault and enable plugins to
> track all the memory operations for the x86 save/restore helpers. As
> we also want to run the slow path when instrumenting *-user we should
> also not have the short cutting test_ptr macro.
> 
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2489
> Fixes: 6d03226b42 (plugins: force slow path when plugins instrument memory ops)
> Reviewed-by: Alexandre Iooss<erdnaxe@crans.org>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Message-Id:<20240807160236.2478459-1-alex.bennee@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~