From: zhenwei pi <pizhenwei@bytedance.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: kbusch@kernel.org, k.jensen@samsung.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, hch@lst.de
Subject: Re: Re: [PATCH 0/2] hw/nvme: support smart AEN
Date: Mon, 9 May 2022 20:36:56 +0800 [thread overview]
Message-ID: <1d3ffa3e-24a2-967c-4353-04fc5280bad6@bytedance.com> (raw)
In-Reply-To: <Ynj3OArUqeiCMyVc@apples>
On 5/9/22 19:12, Klaus Jensen wrote:
> On May 7 15:26, zhenwei pi wrote:
>> Hi,
>> In this series, firstly introduce smart related bits of aen cfg, then
>> support this in oaes.
>>
>> Linux guest does not support this currently, I also send a series to
>> enable smart AEN:
>> https://lore.kernel.org/lkml/20220507065026.260306-1-pizhenwei@bytedance.com/T/#t
>>
>> Test the two series together, works fine.
>>
>> Zhenwei Pi (2):
>> hw/nvme: introduce smart bits of aen cfg
>> hw/nvme: support smart AEN
>>
>> hw/nvme/ctrl.c | 9 ++++++++-
>> include/block/nvme.h | 8 +++++++-
>> 2 files changed, 15 insertions(+), 2 deletions(-)
>>
>
> I'm not quite sure what you are trying to achieve here. Bits 0 through 7
> are reserved in OAES, they are not optional.
>
> We already simply accept whatever the host configured with the
> Asynchronous Event Configuration feature. And you added the support for
> triggering custom AENs for those through the monitor.
Oh, sorry, I misunderstand OAES[7:0]. Thanks for pointing this out!
--
zhenwei pi
prev parent reply other threads:[~2022-05-09 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 7:26 [PATCH 0/2] hw/nvme: support smart AEN zhenwei pi
2022-05-07 7:26 ` [PATCH 1/2] hw/nvme: introduce smart bits of aen cfg zhenwei pi
2022-05-07 7:26 ` [PATCH 2/2] hw/nvme: support smart AEN zhenwei pi
2022-05-09 11:12 ` [PATCH 0/2] " Klaus Jensen
2022-05-09 12:36 ` zhenwei pi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3ffa3e-24a2-967c-4353-04fc5280bad6@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=hch@lst.de \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).