From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm: Display helpful message when hflags mismatch
Date: Wed, 11 Dec 2019 16:36:24 -0800 [thread overview]
Message-ID: <1d51109a-ae9f-7bfe-66d4-0e1e1266df64@linaro.org> (raw)
In-Reply-To: <87d0cx32vv.fsf@linaro.org>
On 12/9/19 8:00 AM, Alex Bennée wrote:
>> -#ifdef CONFIG_DEBUG_TCG
>> - assert(flags == rebuild_hflags_internal(env));
>> -#endif
>> + assert_hflags_rebuild_correctly(env);
>
> I'm trying to recall why we don't just use:
>
> g_assert_cmphex(flags, =, rebuild_hflags_internal(env))
>
> I think it came up in one of the reviews.
checkpatch.pl.
Because, I believe, there is an environment variable that causes this to *not*
abort on mismatch.
r~
next prev parent reply other threads:[~2019-12-12 0:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 13:45 [PATCH] target/arm: Display helpful message when hflags mismatch Philippe Mathieu-Daudé
2019-12-09 16:00 ` Alex Bennée
2019-12-12 0:36 ` Richard Henderson [this message]
2019-12-15 4:56 ` Philippe Mathieu-Daudé
2019-12-09 19:05 ` no-reply
2019-12-09 19:10 ` no-reply
2019-12-17 16:02 ` Richard Henderson
2019-12-17 16:08 ` Peter Maydell
2019-12-17 16:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d51109a-ae9f-7bfe-66d4-0e1e1266df64@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).