From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdFv-0000PC-1H for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpdFr-0006zv-2U for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:28:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdFq-0006zh-Ou for qemu-devel@nongnu.org; Thu, 29 Sep 2016 11:28:10 -0400 References: <20160909220057-mutt-send-email-mst@kernel.org> <718d4b1f-2b2f-fefb-1175-73f07d962343@redhat.com> <20160910003052-mutt-send-email-mst@kernel.org> From: Thomas Huth Message-ID: <1d52c93f-e6e8-3b5c-531e-45c2fb545812@redhat.com> Date: Thu, 29 Sep 2016 17:28:06 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] kvm test warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , "Michael S. Tsirkin" Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Peter Maydell , Marcel Apfelbaum , David Gibson , =?UTF-8?Q?Alex_Benn=c3=a9e?= On 29.09.2016 17:16, Laurent Vivier wrote: > > > On 09/09/2016 23:31, Michael S. Tsirkin wrote: >> On Fri, Sep 09, 2016 at 09:24:45PM +0200, Thomas Huth wrote: >>> On 09.09.2016 21:03, Michael S. Tsirkin wrote: >>>> I am running make test on a box without kvm, and I am seeing these warnings: >>>> >>>> GTESTER check-qtest-ppc64 >>>> "kvm" accelerator not found. >>>> "kvm" accelerator not found. >>>> GTESTER check-qtest-x86_64 >>>> Could not access KVM kernel module: No such file or directory >>>> failed to initialize KVM: No such file or directory >>>> Back to tcg accelerator. >>>> Could not access KVM kernel module: No such file or directory >>>> failed to initialize KVM: No such file or directory >>>> Back to tcg accelerator. >>>> >>>> This is with >>>> commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf >>>> Merge: 5f31bbf f8042de >>>> Author: Peter Maydell >>>> Date: Fri Sep 9 12:49:41 2016 +0100 >>>> >>>> I originally thought this is due to Marcel's test change, >>>> but it triggers without ask well. >>>> >>>> Help will be appreciated. >>> >>> See this thread here: >>> >>> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg05809.html >>> >>> It's not so easy to avoid this warning ... suggestions are welcome... >>> >>> Thomas >> >> >> Really, we just need to add a command line argument >> "--suppress-test-warnings" and pass it in from test framework. >> > > What do you think of only displaying the error on the last accelerator > of the list? > > --- a/accel.c > +++ b/accel.c > @@ -99,7 +99,12 @@ void configure_accelerator(MachineState *ms) > p = get_opt_name(buf, sizeof(buf), p, ':'); > acc = accel_find(buf); > if (!acc) { > - fprintf(stderr, "\"%s\" accelerator not found.\n", buf); > + if (*p != ':') { > + /* to avoid to pollute logs, display error only > + * on the last accelerator of the list > + */ > + fprintf(stderr, "\"%s\" accelerator not found.\n", buf); > + } > continue; > } > if (acc->available && !acc->available()) { > > The accelerator list can be seen as a failover list, so I don't think we > have to display an error in this case as it is the expected behavior. Sounds reasonable to me. Thomas