qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg
@ 2018-02-07  9:29 Nageswara R Sastry
  2018-02-07  9:49 ` no-reply
  2018-02-07  9:58 ` no-reply
  0 siblings, 2 replies; 11+ messages in thread
From: Nageswara R Sastry @ 2018-02-07  9:29 UTC (permalink / raw)
  To: qemu-devel; +Cc: rnsastry

Detected by by Coverity (CID 1385425)
with out this break statement the assigned value of 'tgt_len' at
line 1824 will be replaced by value of 'tgt_len' at line 1830.

Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
---
 linux-user/syscall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 74378947f0..3ecd533880 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1826,6 +1826,7 @@ static inline abi_long host_to_target_cmsg(struct target_msghdr *target_msgh,
             default:
                 break;
             }
+        break;
         default:
             tgt_len = len;
             break;
-- 
2.14.3 (Apple Git-98)

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg
@ 2018-02-07  6:26 Nageswara R Sastry
  2018-02-07 14:53 ` no-reply
  2018-02-07 15:02 ` no-reply
  0 siblings, 2 replies; 11+ messages in thread
From: Nageswara R Sastry @ 2018-02-07  6:26 UTC (permalink / raw)
  To: qemu-devel; +Cc: rnsastry

Detected by by Coverity (CID 1385425)
with out this break statement the assigned value of 'tgt_len' at
line 1824 will be replaced by value of 'tgt_len' at line 1830.

Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
---
 linux-user/syscall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 74378947f0..3ecd533880 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1826,6 +1826,7 @@ static inline abi_long host_to_target_cmsg(struct target_msghdr *target_msgh,
             default:
                 break;
             }
+        break;
         default:
             tgt_len = len;
             break;
-- 
2.14.3 (Apple Git-98)

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-02-16  9:41 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-07  9:29 [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg Nageswara R Sastry
2018-02-07  9:49 ` no-reply
2018-02-07 13:57   ` Laurent Vivier
2018-02-08  5:33     ` Nageswara Sastry
2018-02-08  9:56     ` Nageswara R Sastry
2018-02-15 14:47       ` Laurent Vivier
2018-02-16  9:42         ` Nageswara R Sastry
2018-02-07  9:58 ` no-reply
  -- strict thread matches above, loose matches on Subject: below --
2018-02-07  6:26 Nageswara R Sastry
2018-02-07 14:53 ` no-reply
2018-02-07 15:02 ` no-reply

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).