Re: [Qemu-devel] [PATCH 2/2] tests: send error_report to test log

[Halil Pasic <pasic@linux.vnet.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]



On 10/25/2016 01:34 PM, Paolo Bonzini wrote:
> 
> On 25/10/2016 13:06, Halil Pasic wrote:
>> > 
>> > 
>> > On 10/24/2016 06:31 PM, Paolo Bonzini wrote:
>>> >> Implement error_vprintf to send the output of error_report to
>>> >> the test log.  This silences test-vmstate.
>>> >>
>>> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> > [..]
>>> >>  void error_vprintf(const char *fmt, va_list ap)
>>> >>  {
>>> >> -    vfprintf(stderr, fmt, ap);
>>> >> +    if (g_test_initialized() && !g_test_subprocess()) {
>> > 
>> > I like the approach. What I do not like is:
>> > * we still generate noise only less visible
> It's not noise if it ends up exactly in the right place (the test logs). :)
> 
> Paolo
> 

I assumed (for some strange reason) that the messages (submitted via
g_test_message) will not only appear in the xml report but also in the
html report. I was wrong. And while I still believe that the messages in
question (the vmstate test) do not add any value to the xml report and
on the other hand that situations could emerge where having the error
reported more prominently would be more convenient, I am very much fine
with this solution.

Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]