From: Thomas Huth <thuth@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org
Cc: alistair23@gmail.com, philippe@mathieu-daude.net, armbru@redhat.com
Subject: Re: [Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information
Date: Thu, 6 Jul 2017 04:46:03 +0200 [thread overview]
Message-ID: <1d8284d3-0694-a207-8fe7-f58c0e223988@redhat.com> (raw)
In-Reply-To: <4c63c416af7bffe388d399132a006355366a3cfb.1499276048.git.alistair.francis@xilinx.com>
On 05.07.2017 19:36, Alistair Francis wrote:
> When QEMU is waiting for a TCP socket connection it reports that message as
> an error. This isn't an error it is just information so let's change the
> report to use info_report() instead.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>
> chardev/char-socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index ccc499cfa1..a050a686ea 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -765,8 +765,8 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp)
> * in TLS and telnet cases, only wait for an accepted socket */
> while (!s->ioc) {
> if (s->is_listen) {
> - error_report("QEMU waiting for connection on: %s",
> - chr->filename);
> + info_report("QEMU waiting for connection on: %s",
> + chr->filename);
> qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL);
> tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
> qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
And in case you also want to add some warn_reports, I suggest to do a
grep -r "error_report.*[Ww]arning:" *
in the sources - there seem to be quite a lot of error_reports that are
rather a warning instead.
Thomas
next prev parent reply other threads:[~2017-07-06 2:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:36 [Qemu-devel] [RFC v3 0/3] Implement a warning_report function Alistair Francis
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-06 2:36 ` Thomas Huth
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting Alistair Francis
2017-07-06 2:42 ` Thomas Huth
2017-07-06 6:15 ` Markus Armbruster
2017-07-06 8:07 ` Daniel P. Berrange
2017-07-06 11:27 ` Markus Armbruster
2017-07-06 11:45 ` Daniel P. Berrange
2017-07-06 12:20 ` Markus Armbruster
2017-07-06 13:10 ` Daniel P. Berrange
2017-07-06 14:44 ` Markus Armbruster
2017-07-06 18:45 ` Alistair Francis
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-06 2:46 ` Thomas Huth [this message]
2017-07-06 6:18 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d8284d3-0694-a207-8fe7-f58c0e223988@redhat.com \
--to=thuth@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=armbru@redhat.com \
--cc=philippe@mathieu-daude.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).