From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5F59E81E1B for ; Fri, 6 Oct 2023 17:09:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qooJl-0001pl-4W; Fri, 06 Oct 2023 13:08:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qooJj-0001pd-GK for qemu-devel@nongnu.org; Fri, 06 Oct 2023 13:08:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qooJh-0000Ma-2m for qemu-devel@nongnu.org; Fri, 06 Oct 2023 13:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696612118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oO3hoG5QRhnV0cDCGJeq+RT7uPSEoJKL+ENQ+jYK7/Y=; b=SQKJZjuYtn10AvbiNPrftsnQn44e+Nb03D82DtercEXmAM3YLOsZerczca+9zZCbcpCo88 Jd5rvgymE/4Ece7R0Skp8yfILbYY+LSd5aivSONhTCJtJEBy7y/SKWy3mLYFFLaPr80zje oLxQ7Qd1flqosD601/GBKRQGYKxAHAI= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-7mZ3rmmxNNiqnmG4I5crrQ-1; Fri, 06 Oct 2023 13:08:31 -0400 X-MC-Unique: 7mZ3rmmxNNiqnmG4I5crrQ-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-41975c9e66fso37659451cf.0 for ; Fri, 06 Oct 2023 10:08:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696612110; x=1697216910; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oO3hoG5QRhnV0cDCGJeq+RT7uPSEoJKL+ENQ+jYK7/Y=; b=JWExAJpahuNNlZbwUoyAPs2Wt2JLkyWBRKZ0mQBgFK5eftlJzWyRmrW1eTDP/tA7zY Wf1sQB0s71HkxPnHbGEoYg6qyefYhtGYcq38ggEciYV89argVu1XTaDsBK6k/kAauXJ2 MakC10VuDrcCQfhVFyDybhoidP1c1IBlfbRUdnGGj8Yb++AMo5R5bxYxl0QzPAcrJFXG aSx3zddnoJ0x0VEgerrHlLUjV089kxZ32DVkxQLE03rY4CI54bV7M6yEKrcfZfktS4uk VKejfxhPysDQIsRaw4QDblXTCpLysAh1SqjOA0ukWivsJ0IJmiCAbTgg5a6efzHNOLdZ 3c4Q== X-Gm-Message-State: AOJu0YxpYcle2iclzSIwW8m+PvNENa3C+3TGhvnFlyMb/m8kM49Hpxd0 9b6D7G9ty2dtd123wVWyI1PiSn/J++IxIjcZ1//P+ie19rAJECrsLnjaswe+9Y/vrzs5pEGH5hU B0b+7BpvfZfpAwzw= X-Received: by 2002:a05:622a:38e:b0:403:b088:5d3 with SMTP id j14-20020a05622a038e00b00403b08805d3mr6517018qtx.17.1696612110504; Fri, 06 Oct 2023 10:08:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyvS84MMKnm0CnxagSzVt/wD16Fj5VUsA+Ye4lnwQcNmBkOooUXpJ/+0Y34dHB+VakRUFXVQ== X-Received: by 2002:a05:622a:38e:b0:403:b088:5d3 with SMTP id j14-20020a05622a038e00b00403b08805d3mr6516991qtx.17.1696612110163; Fri, 06 Oct 2023 10:08:30 -0700 (PDT) Received: from ?IPV6:2a01:cb19:853d:fa00:c28a:3e3d:34f3:3891? ([2a01:cb19:853d:fa00:c28a:3e3d:34f3:3891]) by smtp.gmail.com with ESMTPSA id he24-20020a05622a601800b00419b67d2823sm1410803qtb.34.2023.10.06.10.08.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 10:08:29 -0700 (PDT) Message-ID: <1d87070c-2561-c6da-1380-9e3e13bcd844@redhat.com> Date: Fri, 6 Oct 2023 19:08:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PULL 00/21] vfio queue Content-Language: en-US To: Eric Auger , qemu-devel@nongnu.org, Stefan Hajnoczi Cc: Alex Williamson , Matthew Rosato References: <20231006062005.1040296-1-clg@redhat.com> <1e2652d6-c10b-9b65-6e2c-7903574d501a@redhat.com> <3ea30f06-aeea-8e66-a8ed-75a9292a415f@redhat.com> <1c19badf-0c65-4ee0-61a0-e653b7be89bf@redhat.com> <58d75d69-cfd8-903e-c0a1-f95acc64bfd0@redhat.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <58d75d69-cfd8-903e-c0a1-f95acc64bfd0@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -48 X-Spam_score: -4.9 X-Spam_bar: ---- X-Spam_report: (-4.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.797, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Eric, On 10/6/23 14:25, Eric Auger wrote: > Hi Cédric, > > On 10/6/23 13:46, Eric Auger wrote: >> Hi Cédric, >> >> On 10/6/23 13:42, Eric Auger wrote: >>> Hi Cédric, >>> >>> On 10/6/23 12:33, Cédric Le Goater wrote: >>>> On 10/6/23 08:19, Cédric Le Goater wrote: >>>>> The following changes since commit >>>>> 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d: >>>>> >>>>>    Merge tag 'for_upstream' of >>>>> https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging >>>>> (2023-10-05 09:01:01 -0400) >>>>> >>>>> are available in the Git repository at: >>>>> >>>>>    https://github.com/legoater/qemu/ tags/pull-vfio-20231006 >>>>> >>>>> for you to fetch changes up to 6e86aaef9ac57066aa923211a164df95b7b3cdf7: >>>>> >>>>>    vfio/common: Move legacy VFIO backend code into separate >>>>> container.c (2023-10-05 22:04:52 +0200) >>>>> >>>>> ---------------------------------------------------------------- >>>>> vfio queue: >>>>> >>>>> * Fix for VFIO display when using Intel vGPUs >>>>> * Support for dynamic MSI-X >>>>> * Preliminary work for IOMMUFD support >>>> >>>> Stefan, >>>> >>>> I just did some tests on z with passthough devices (PCI and AP) and >>>> the series is not bisectable. QEMU crashes at patch  : >>>> >>>>   "vfio/pci: Introduce vfio_[attach/detach]_device". >>>> >>>> Also, with everything applied, the guest fails to start with : >>>> >>>>  vfio: IRQ 0 not available (number of irqs 0) >>>> >>>> So, please hold on and sorry for the noise. I will start digging >>>> on my side. >>> I just tested with the head on vfio/pci: Introduce >>> vfio_[attach/detach]_device, with PCIe assignment on ARM and I fail to >>> reproduce the crash. >>> >>> Do you try hotplug or something simpler? >> >> also works for me with hotplug/hotunplug. Please let me know if I can help. > > I think this is related to the error handling. > > if you hotplug a vfio-device and if this encounters an error, > vfio_realize fails and you end at the 'error' label where the name of > the device is freed: g_free(vbasedev->name); > > However I see that the vfio_finalize is called (Zhengzhong warned me !!) > calls vfio_pci_put_device > which calls g_free(vdev->vbasedev.name) again. > please try adding > vdev->vbasedev.name = NULL after freeing the name in vfio_realize error: > so see if it fixes the crash. > > Then wrt irq stuff, I would be tempted to say it sounds unrelated to the > iommufd prereq series but well. > > Please let me know how you want me to fix that mess, sorry. So, the issue was a bit complex to dig because it only crashed with a s390 guest under libvirt. This is my all-in-one combo VM which has 2 PCI, 2 AP, 1 CCW passthrough devices and the issue is in AP I think. vfio_ap_realize lacks : @@ -188,6 +188,7 @@ static void vfio_ap_realize(DeviceState error_report_err(err); } + return; error: error_prepend(errp, VFIO_MSG_PREFIX, vbasedev->name); g_free(vbasedev->name); No error were to return and since everything was fine, the error path generated a lot of mess indeed ! If you are ok with the above, I will squash the change in the related patch and send a v2. Thanks, C. > > Eric > > >> >> Eric >>> >>> Thanks >>> >>> Eric >>> >>> >>>> >>>> Thanks, >>>> >>>> C. >>>> >>>>> ---------------------------------------------------------------- >>>>> Alex Williamson (1): >>>>>        vfio/display: Fix missing update to set backing fields >>>>> >>>>> Eric Auger (7): >>>>>        scripts/update-linux-headers: Add iommufd.h >>>>>        vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any >>>>>        vfio/common: Introduce vfio_container_add|del_section_window() >>>>>        vfio/pci: Introduce vfio_[attach/detach]_device >>>>>        vfio/platform: Use vfio_[attach/detach]_device >>>>>        vfio/ap: Use vfio_[attach/detach]_device >>>>>        vfio/ccw: Use vfio_[attach/detach]_device >>>>> >>>>> Jing Liu (4): >>>>>        vfio/pci: detect the support of dynamic MSI-X allocation >>>>>        vfio/pci: enable vector on dynamic MSI-X allocation >>>>>        vfio/pci: use an invalid fd to enable MSI-X >>>>>        vfio/pci: enable MSI-X in interrupt restoring on dynamic >>>>> allocation >>>>> >>>>> Yi Liu (2): >>>>>        vfio/common: Move IOMMU agnostic helpers to a separate file >>>>>        vfio/common: Move legacy VFIO backend code into separate >>>>> container.c >>>>> >>>>> Zhenzhong Duan (7): >>>>>        vfio/pci: rename vfio_put_device to vfio_pci_put_device >>>>>        linux-headers: Add iommufd.h >>>>>        vfio/common: Extract out vfio_kvm_device_[add/del]_fd >>>>>        vfio/common: Move VFIO reset handler registration to a group >>>>> agnostic function >>>>>        vfio/common: Introduce a per container device list >>>>>        vfio/common: Store the parent container in VFIODevice >>>>>        vfio/common: Introduce a global VFIODevice list >>>>> >>>>>   hw/vfio/pci.h                   |    1 + >>>>>   include/hw/vfio/vfio-common.h   |   60 +- >>>>>   linux-headers/linux/iommufd.h   |  444 +++++++++ >>>>>   hw/vfio/ap.c                    |   69 +- >>>>>   hw/vfio/ccw.c                   |  122 +-- >>>>>   hw/vfio/common.c                | 1885 >>>>> +++------------------------------------ >>>>>   hw/vfio/container.c             | 1161 ++++++++++++++++++++++++ >>>>>   hw/vfio/display.c               |    2 + >>>>>   hw/vfio/helpers.c               |  612 +++++++++++++ >>>>>   hw/vfio/pci.c                   |  194 ++-- >>>>>   hw/vfio/platform.c              |   43 +- >>>>>   hw/vfio/meson.build             |    2 + >>>>>   hw/vfio/trace-events            |    6 +- >>>>>   scripts/update-linux-headers.sh |    3 +- >>>>>   14 files changed, 2580 insertions(+), 2024 deletions(-) >>>>>   create mode 100644 linux-headers/linux/iommufd.h >>>>>   create mode 100644 hw/vfio/container.c >>>>>   create mode 100644 hw/vfio/helpers.c >>>>> >>>> >