From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 074E6C433E0 for ; Wed, 13 May 2020 20:36:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D5F8205ED for ; Wed, 13 May 2020 20:36:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bGqbKMdZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D5F8205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYy6y-00058f-0E for qemu-devel@archiver.kernel.org; Wed, 13 May 2020 16:36:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYy3z-0001km-5l for qemu-devel@nongnu.org; Wed, 13 May 2020 16:33:11 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53640 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYy3y-0006J5-C1 for qemu-devel@nongnu.org; Wed, 13 May 2020 16:33:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589401989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ubEdXYk0yCRGB0JhU9wye9DBEstwBWDPX/d9X+foojA=; b=bGqbKMdZXIyUPitU4oemP23xOKfT5KoZWLK3drBbsq+gBgNHfW400oR4KBJRn0sSxQADLT 5GpCJZRitxaumHjKCetWmLT0D6jYSViggCCaEvIlrIpeOQhvb8XR+X4lhkuQsAa58Xcmcp 8ftwoOHyyHaKJMdu50BlsRpdczOJVD4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-KUwYI_BoP_yxdaMxMe2gDw-1; Wed, 13 May 2020 16:33:07 -0400 X-MC-Unique: KUwYI_BoP_yxdaMxMe2gDw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B1038015CE; Wed, 13 May 2020 20:33:06 +0000 (UTC) Received: from [10.3.116.145] (ovpn-116-145.phx2.redhat.com [10.3.116.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E68B610013D9; Wed, 13 May 2020 20:33:05 +0000 (UTC) Subject: Re: [PATCH v4 16/34] block: Pull out bdrv_default_perms_for_cow() To: Max Reitz , qemu-block@nongnu.org References: <20200513110544.176672-1-mreitz@redhat.com> <20200513110544.176672-17-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <1d9c968f-a98a-089d-236c-5070f936361f@redhat.com> Date: Wed, 13 May 2020 15:33:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200513110544.176672-17-mreitz@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 01:56:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/13/20 6:05 AM, Max Reitz wrote: > Right now, bdrv_format_default_perms() is used by format parents > (generally). We want to switch to a model where most parents use a > single BdrvChildClass, which then decides the permissions based on the > child role. To do so, we have to split bdrv_format_default_perms() into > separate functions for each such role. > > Signed-off-by: Max Reitz > --- > block.c | 62 +++++++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 40 insertions(+), 22 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org