From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
qemu-devel@nongnu.org, "Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary
Date: Tue, 26 Jan 2021 20:38:14 +0100 [thread overview]
Message-ID: <1da8f947-adda-312c-b0d4-a81f362b0447@redhat.com> (raw)
In-Reply-To: <87sg6n1xyz.fsf@dusky.pond.sub.org>
On 1/26/21 5:09 PM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> On 1/26/21 3:57 PM, Alex Bennée wrote:
>>>
>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>
>>>> In this series we deselect a bunch of features when they
>>>> not required, so less objects are built.
>>>>
>>>> While this reduce pressure on CI and slow systems, this is
>>>> particularly helpful for developers regularly testing multiple
>>>> build configurations.
>>>>
>>>> All CI tests pass:
>>>> https://gitlab.com/philmd/qemu/-/pipelines/245654160
>>>>
>>>> Supersedes: <20210120151916.1167448-1-philmd@redhat.com>
>>>
>>> Series looks good to me but I guess you need some sub-system feedback.
>>
>> Yeah, I will wait for Markus feedback on qapi/ before respining (with
>> target/ fix), ...
>
> Maybe I'm naive today, but to me this looks like a case of "if it still
> builds, it's fine".
>
> Anything in particular you want my feedback for?
You are listed as qapi/ maintainer with Michael :)
QAPI
M: Markus Armbruster <armbru@redhat.com>
M: Michael Roth <michael.roth@amd.com>
S: Supported
F: qapi/
If it is fine to you, then I'll respin addressing Paolo's comments.
Thanks :)
Phil.
next prev parent reply other threads:[~2021-01-26 19:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 20:44 [PATCH v2 00/12] buildsys: Do not build various objects if not necessary Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 01/12] configure: Only check for audio drivers if system-mode is selected Philippe Mathieu-Daudé
2021-01-25 14:52 ` Alex Bennée
2021-01-22 20:44 ` [PATCH v2 02/12] tests/meson: Only build softfloat objects if TCG " Philippe Mathieu-Daudé
2021-01-23 12:19 ` Claudio Fontana
2021-01-25 15:05 ` Alex Bennée
2021-01-22 20:44 ` [PATCH v2 03/12] pc-bios/meson: Only install EDK2 blob firmwares with system emulation Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 04/12] meson: Do not build optional libraries by default Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 05/12] meson: Restrict block subsystem processing Philippe Mathieu-Daudé
2021-01-25 12:15 ` Kevin Wolf
2021-01-25 18:51 ` Paolo Bonzini
2021-01-22 20:44 ` [PATCH v2 06/12] meson: Merge trace_events_subdirs array Philippe Mathieu-Daudé
2021-01-23 12:29 ` Claudio Fontana
2021-01-22 20:44 ` [PATCH v2 07/12] meson: Restrict some trace event directories to user/system emulation Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 08/12] meson: Restrict emulation code Philippe Mathieu-Daudé
2021-01-25 15:09 ` Philippe Mathieu-Daudé
2021-01-25 15:12 ` Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation Philippe Mathieu-Daudé
2021-01-23 18:10 ` Paolo Bonzini
2021-01-24 0:32 ` Philippe Mathieu-Daudé
2021-01-26 15:46 ` Paolo Bonzini
2021-01-22 20:44 ` [PATCH v2 10/12] qapi/meson: Remove QMP from user-mode emulation Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 11/12] qapi/meson: Restrict system-mode specific modules Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 12/12] qapi/meson: Restrict UI module to system emulation and tools Philippe Mathieu-Daudé
2021-01-23 18:11 ` [PATCH v2 00/12] buildsys: Do not build various objects if not necessary Paolo Bonzini
2021-01-26 14:57 ` Alex Bennée
2021-01-26 15:28 ` Philippe Mathieu-Daudé
2021-01-26 16:09 ` Markus Armbruster
2021-01-26 19:38 ` Philippe Mathieu-Daudé [this message]
2021-01-27 8:42 ` Markus Armbruster
2021-01-29 8:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da8f947-adda-312c-b0d4-a81f362b0447@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).