From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: "Brenken, David (EFS-GH2)" <david.brenken@efs-auto.de>,
Richard Henderson <richard.henderson@linaro.org>,
David Brenken <david.brenken@efs-auto.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Biermanski, Lars \(EFS-GH3\)" <lars.biermanski@efs-auto.de>,
"Rasche, Robert \(EFS-GH2\)" <robert.rasche@efs-auto.de>,
"Hofstetter, Georg \(EFS-GH2\)" <Georg.Hofstetter@efs-auto.de>,
"Konopik, Andreas \(EFS-GH2\)" <andreas.konopik@efs-auto.de>
Subject: Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction
Date: Wed, 12 Jun 2019 13:52:36 +0200 [thread overview]
Message-ID: <1dc1af82-88cf-5840-dfad-ff0a75e3dcec@mail.uni-paderborn.de> (raw)
In-Reply-To: <34F764F04E859040BBA6C4FF41AB17D93B4A3D@AUDIINSX0410.audi.vwg>
Hi David,
On 6/12/19 7:48 AM, Brenken, David (EFS-GH2) wrote:
> Thank you for your hint.
> Would anyone mind, if keep my insert implementation anyway?
> If I compare the pseudo code of the instruction manual to the insert implementation it looks nearly the same whereas it seems kind of difficult to directly map the pseudo code of the instruction manual to the general deposit instruction.
I think deposit is better, as tcg can emit the native deposit
instruction of the host processor (which it does for x86). gen_insert()
on the other hand needs 8 tcg ops.
Regarding the pseudo code, take a look at tcg/README. You'll see that
the semantics of insert and deposit are the same. Thus, I think Richards
fix is better.
Cheers,
Bastian
next prev parent reply other threads:[~2019-06-12 11:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 6:11 [Qemu-devel] [PATCH 0/5] tricore: adding new instructions and fixing issues David Brenken
2019-06-05 6:11 ` [Qemu-devel] [PATCH 1/5] tricore: add FTOIZ instruction David Brenken
2019-06-05 14:27 ` Bastian Koppelmann
2019-06-05 6:11 ` [Qemu-devel] [PATCH 2/5] tricore: add UTOF instruction David Brenken
2019-06-05 14:34 ` Bastian Koppelmann
2019-06-05 6:11 ` [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction David Brenken
2019-06-05 14:34 ` Bastian Koppelmann
2019-06-06 7:26 ` Brenken, David (EFS-GH2)
2019-06-07 12:48 ` Richard Henderson
2019-06-12 5:48 ` Brenken, David (EFS-GH2)
2019-06-12 11:52 ` Bastian Koppelmann [this message]
2019-06-05 6:11 ` [Qemu-devel] [PATCH 4/5] tricore: add QSEED instruction David Brenken
2019-06-05 15:04 ` Bastian Koppelmann
2019-06-07 8:40 ` Konopik, Andreas (EFS-GH2)
2019-06-05 6:11 ` [Qemu-devel] [PATCH 5/5] tricore: reset DisasContext before generating code David Brenken
2019-06-05 9:01 ` Bastian Koppelmann
2019-06-06 11:44 ` Hofstetter, Georg (EFS-GH2)
2019-06-06 14:24 ` Bastian Koppelmann
2019-06-05 15:10 ` [Qemu-devel] [PATCH 0/5] tricore: adding new instructions and fixing issues Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc1af82-88cf-5840-dfad-ff0a75e3dcec@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=Georg.Hofstetter@efs-auto.de \
--cc=andreas.konopik@efs-auto.de \
--cc=david.brenken@efs-auto.de \
--cc=david.brenken@efs-auto.org \
--cc=lars.biermanski@efs-auto.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.rasche@efs-auto.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).