qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: "Zhao Liu" <zhao1.liu@intel.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>
Cc: Ewan Hai <ewanhai-oc@zhaoxin.com>,
	Jason Zeng <jason.zeng@intel.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>, Tao Su <tao1.su@intel.com>,
	Yi Lai <yi1.lai@intel.com>, Dapeng Mi <dapeng1.mi@intel.com>,
	Tejus GK <tejus.gk@nutanix.com>,
	Manish Mishra <manish.mishra@nutanix.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 7/8] i386/cpu: Enable 0x1f leaf for GraniteRapids by default
Date: Fri, 4 Jul 2025 11:47:42 +0800	[thread overview]
Message-ID: <1dc7cdfd-b34a-4f7c-b9f1-8c24861c8272@linux.intel.com> (raw)
In-Reply-To: <20250626083105.2581859-8-zhao1.liu@intel.com>


On 6/26/2025 4:31 PM, Zhao Liu wrote:
> Host GraniteRapids CPU has 0x1f leaf by default, so that enable it for
> Guest CPU by default as well.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> Changes since RFC:
>  * Rename the property to "x-force-cpuid-0x1f". (Igor)
> ---
>  target/i386/cpu.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 70f8fc37f8e0..acf7e0de184d 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -5242,8 +5242,11 @@ static const X86CPUDefinition builtin_x86_defs[] = {
>              },
>              {
>                  .version = 3,
> -                .note = "with gnr-sp cache model",
> +                .note = "with gnr-sp cache model and 0x1f leaf",

ditto.

Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>

>                  .cache_info = &xeon_gnr_cache_info,
> +                .props = (PropValue[]) {
> +                    { "x-force-cpuid-0x1f", "on" },
> +                }
>              },
>              { /* end of list */ },
>          },


  reply	other threads:[~2025-07-04  3:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26  8:30 [PATCH 0/8] i386/cpu: Intel cache model & topo CPUID enhencement Zhao Liu
2025-06-26  8:30 ` [PATCH 1/8] i386/cpu: Introduce cache model for SierraForest Zhao Liu
2025-07-04  3:33   ` Mi, Dapeng
2025-07-07  0:57   ` Tao Su
2025-06-26  8:30 ` [PATCH 2/8] i386/cpu: Introduce cache model for GraniteRapids Zhao Liu
2025-07-04  3:34   ` Mi, Dapeng
2025-07-07  0:58   ` Tao Su
2025-06-26  8:31 ` [PATCH 3/8] i386/cpu: Introduce cache model for SapphireRapids Zhao Liu
2025-07-04  3:35   ` Mi, Dapeng
2025-07-07  0:58   ` Tao Su
2025-06-26  8:31 ` [PATCH 4/8] i386/cpu: Introduce cache model for YongFeng Zhao Liu
2025-06-29  9:47   ` Ewan Hai
2025-07-02  6:35     ` Zhao Liu
2025-07-02  9:35       ` Ewan Hai
2025-06-26  8:31 ` [PATCH 5/8] i386/cpu: Add a "x-force-cpuid-0x1f" property Zhao Liu
2025-06-26 12:07   ` Ewan Hai
2025-06-27  3:05     ` Zhao Liu
2025-06-27  6:48       ` Ewan Hai
2025-06-27 10:00         ` Zhao Liu
2025-07-04  3:38   ` Mi, Dapeng
2025-06-26  8:31 ` [PATCH 6/8] i386/cpu: Enable 0x1f leaf for SierraForest by default Zhao Liu
2025-07-04  3:45   ` Mi, Dapeng
2025-06-26  8:31 ` [PATCH 7/8] i386/cpu: Enable 0x1f leaf for GraniteRapids " Zhao Liu
2025-07-04  3:47   ` Mi, Dapeng [this message]
2025-06-26  8:31 ` [PATCH 8/8] i386/cpu: Enable 0x1f leaf for SapphireRapids " Zhao Liu
2025-07-04  3:48   ` Mi, Dapeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dc7cdfd-b34a-4f7c-b9f1-8c24861c8272@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=berrange@redhat.com \
    --cc=dapeng1.mi@intel.com \
    --cc=eduardo@habkost.net \
    --cc=ewanhai-oc@zhaoxin.com \
    --cc=imammedo@redhat.com \
    --cc=jason.zeng@intel.com \
    --cc=manish.mishra@nutanix.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tao1.su@intel.com \
    --cc=tejus.gk@nutanix.com \
    --cc=xiaoyao.li@intel.com \
    --cc=yi1.lai@intel.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).