From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu
Date: Thu, 16 Mar 2023 09:50:58 +0100 [thread overview]
Message-ID: <1dc809b6-a51d-eb7c-5828-e9cfae0905f5@vivier.eu> (raw)
In-Reply-To: <c854655d-642c-21dc-61a5-4d93b98fc7b1@linaro.org>
Le 16/03/2023 à 08:52, Philippe Mathieu-Daudé a écrit :
> On 16/3/23 01:34, Ilya Leoshkevich wrote:
>> When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored.
>> Fix by using qemu_fprintf() instead of qemu_printf() in the respective
>> places.
>>
>> Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints")
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
>> ---
>>
>> Resend of https://patchew.org/QEMU/20220725142854.177451-1-iii@linux.ibm.com/
>> with a trivial rebase.
>>
>> target/sh4/translate.c | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2023-03-16 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 0:34 [PATCH v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu Ilya Leoshkevich
2023-03-16 7:52 ` Philippe Mathieu-Daudé
2023-03-16 8:50 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc809b6-a51d-eb7c-5828-e9cfae0905f5@vivier.eu \
--to=laurent@vivier.eu \
--cc=iii@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).