Re: [PATCH 18/32] hw/sd: Add emmc_cmd_APP_CMD() handler

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi Cédric,

On 3/7/23 15:24, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/sd/sd.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 5ff132139ea9..95cb46b87519 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2207,6 +2207,11 @@ static sd_rsp_type_t emmc_cmd_ALL_SEND_CID(SDState *sd, SDRequest req)
>       return sd_r2_i;
>   }
>   
> +static sd_rsp_type_t emmc_cmd_APP_CMD(SDState *sd, SDRequest req)
> +{
> +    return sd_r0;

Why are you returning R0? This is invalid, only R1 can be
returned by APP_CMD.

> +}
> +
>   static const SDProto sd_proto_emmc = {
>       .name = "eMMC",
>       .cmd = {
> @@ -2219,6 +2224,7 @@ static const SDProto sd_proto_emmc = {
>           [23]        = sd_cmd_SET_BLOCK_COUNT,
>           [41]        = sd_cmd_illegal,
>           [52 ... 54] = sd_cmd_illegal,
> +        [55]        = emmc_cmd_APP_CMD,
>           [58]        = sd_cmd_illegal,
>           [59]        = sd_cmd_illegal,
>       },