Re: [PULL 00/32] Misc HW patches for 2025-02-10

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 11/2/25 19:48, Philippe Mathieu-Daudé wrote:
> On 11/2/25 19:26, Stefan Hajnoczi wrote:
>> On Mon, Feb 10, 2025 at 3:43 PM Philippe Mathieu-Daudé
>> <philmd@linaro.org> wrote:
>>>
>>> The following changes since commit 
>>> 54e91d1523b412b4cff7cb36c898fa9dc133e886:
>>>
>>>    Merge tag 'pull-qapi-2025-02-10-v2' of https://repo.or.cz/qemu/ 
>>> armbru into staging (2025-02-10 10:47:31 -0500)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://github.com/philmd/qemu.git tags/hw-misc-20250210
>>>
>>> for you to fetch changes up to 1078a376932cc1d1c501ee3643fef329da6a189a:
>>>
>>>    hw/net/smc91c111: Ignore attempt to pop from empty RX fifo 
>>> (2025-02-10 21:30:44 +0100)
>>>
>>> ----------------------------------------------------------------
>>> Misc HW patches
>>>
>>> - Use qemu_hexdump_line() in TPM backend (Philippe)
>>> - Make various Xilinx devices endianness configurable (Philippe)
>>> - Remove magic number in APIC (Phil)
>>> - Disable thread-level cache topology (Zhao)
>>> - Xen QOM style cleanups (Bernhard)
>>> - Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE (Philippe)
>>> - Invert logic of machine no_sdcard flag (Philippe)
>>> - Housekeeping in MicroBlaze functional tests (Philippe)
>>
>> Please take a look at this CI failure:
>> https://gitlab.com/qemu-project/qemu/-/jobs/9106591368
> 
> Hmm I can not reproduce locally this error:
> 
>    Exception: Asset cache is invalid and downloads disabled

OK, I could reproduce by blowing my cache away.

The problem seems in the "tests/functional: Have microblaze tests
inherit common parent class" patch, which does:

-class MicroblazeelMachine(QemuSystemTest):
+class MicroblazeLittleEndianMachine(MicroblazeMachine):

I presume, since MicroblazeLittleEndianMachine is no more a direct
child of QemuSystemTest, then the ASSET_IMAGE_* aren't automatically
downloaded.

> https://gitlab.com/qemu-project/qemu/-/jobs/9106591368/artifacts/ 
> external_file/build/tests/functional/microblazeel/ 
> test_microblazeel_s3adsp1800.MicroblazeLittleEndianMachine.test_microblaze_s3adsp1800_legacy_le/base.log content is:
> 
>    2025-02-11 16:24:55,525 - DEBUG: Extract /builds/qemu-project/qemu/ 
> functional-cache/download/ 
> b9b3d43c5dd79db88ada495cc6e0d1f591153fe41355e925d791fbf44de50c22 
> format=Nonesub_dir=None member=None
> 
> which is correct:
> 
> $ sha256sum day13.tar.gz
> b9b3d43c5dd79db88ada495cc6e0d1f591153fe41355e925d791fbf44de50c22 
> day13.tar.gz
> 
> Did you restart the job to see if it is a network issue?
> 
> Regards,
> 
> Phil.