From: Richard Henderson <richard.henderson@linaro.org>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: "Bonzini, Paolo" <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check
Date: Mon, 28 Feb 2022 08:42:51 -1000 [thread overview]
Message-ID: <1de62df7-be40-c8b1-dfcf-ae57096ba19c@linaro.org> (raw)
In-Reply-To: <CAFEAcA8Qz1gpb+m7c4isagPG357NjwLtm3hfrmrnG8zYqEqKdw@mail.gmail.com>
On 2/28/22 03:36, Peter Maydell wrote:
> I think we should have the 128-bit atomics check in meson.build
> look the same as the existing one for 64-bit atomics, though,
> unless there's a reason why they should look different.
> For the 64-bit version we explicitly pass __ATOMIC_RELAXED,
> and we use __atomic_load_n(), not __atomic_load().
Yep, since that's what we use in qatomic_read__nocheck, etc.
r~
prev parent reply other threads:[~2022-02-28 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 12:07 [PATCH 1/2] meson: move int128 checks from configure marcandre.lureau
2022-02-28 12:07 ` [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check marcandre.lureau
2022-02-28 12:43 ` Philippe Mathieu-Daudé
2022-02-28 13:24 ` Peter Maydell
2022-02-28 13:28 ` Marc-André Lureau
2022-02-28 13:36 ` Peter Maydell
2022-02-28 18:42 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de62df7-be40-c8b1-dfcf-ae57096ba19c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).