From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08AEFC433DF for ; Tue, 28 Jul 2020 13:22:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6117206D7 for ; Tue, 28 Jul 2020 13:22:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RCyQtq0E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6117206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0PYO-0000MW-RK for qemu-devel@archiver.kernel.org; Tue, 28 Jul 2020 09:22:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0PXm-0008IP-Sf for qemu-devel@nongnu.org; Tue, 28 Jul 2020 09:21:22 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:58758 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k0PXk-0008KW-BY for qemu-devel@nongnu.org; Tue, 28 Jul 2020 09:21:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595942478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dN4MwuLd052zIUtAcaPQJYj8/OZnqZKMljCsKYuyf4Q=; b=RCyQtq0EYig7bNq+9X/eNrMVNQDzsPfOq25VvporcKS9CS7w/CNiFaryAEIszxJ+Q21IbR UUWXvz6RhrZ+tdHM8OZx0/DJ5M7+3bvHgtkBcjBg8VG0aSSgAVHB6tiYVlaOD5nZBWmGbK enzgmkLSAWcuX1i0rxz4QGqj5OgNo+Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-BUT57htTNKKWBV8w9N7vQw-1; Tue, 28 Jul 2020 09:21:14 -0400 X-MC-Unique: BUT57htTNKKWBV8w9N7vQw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53430800471; Tue, 28 Jul 2020 13:21:13 +0000 (UTC) Received: from [10.10.118.248] (ovpn-118-248.rdu2.redhat.com [10.10.118.248]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4EA171D0E; Tue, 28 Jul 2020 13:21:09 +0000 (UTC) Subject: Re: [PATCH] iotests/197: Fix for non-qcow2 formats To: Max Reitz , qemu-block@nongnu.org References: <20200728122125.273230-1-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <1de9634f-6d49-fe2d-b049-c5f2aa27d67a@redhat.com> Date: Tue, 28 Jul 2020 08:21:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728122125.273230-1-mreitz@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 23:55:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/28/20 7:21 AM, Max Reitz wrote: > While 197 is very much a qcow2 test, and it looks like the partial > cluster case at the end (introduced in b0ddcbbb36a66a6) is specifically > a qcow2 case, the whole test scripts actually marks itself to work with > generic formats (and generic protocols, even). > > Said partial cluster case happened to work with non-qcow2 formats as > well (mostly by accident), but 1855536256 broke that, because it sets > the compat option, which does not work for non-qcow2 formats. > > So go the whole way and force IMGFMT=qcow2 and IMGPROTO=file, as done in > other places in this test. > > Fixes: 1855536256eb0a5708b04b85f744de69559ea323 > Reported-by: Thomas Huth > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/197 | 8 +++++--- > tests/qemu-iotests/197.out | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org