From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83516CCD1BF for ; Fri, 24 Oct 2025 19:36:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vCNZh-00033N-LV; Fri, 24 Oct 2025 15:35:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCNZg-000338-MF; Fri, 24 Oct 2025 15:35:44 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCNZe-0002K1-VQ; Fri, 24 Oct 2025 15:35:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:MIME-Version:Date:Message-ID:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=T4i8sDpuHvrwzUGeslbHeKNqol7x9EIPsynwvGbYDuE=; b=1qoRm7rn9UE5hV1ICpPRTjsHoU ist1h0fufzsR7NYmH6g7uj1GyZ8His+4RxxuVBpNPglvl1snQNZ2DC7+ATynsZLem89c95KaorZbB bHso/H8zngqfaI/rjoCxm9C0WR3huPWL/qceFDSs8aMvLPI48pyOq12R4VSfsdCBFhaeXI1q/tviD mwKz2igVf20W8nU3eZ8KA03iQguTK84xCozNYVjjaueKh+ye/PgKARknBPSA5OkP5qHcAToWnnnHs kUcakrBLKtZA1gnRV/RVQiOfRdDh4UT5zG2ad2mtNyDsgI/OfT0KiXHfJvGnqw75y1ODbT/zlufzJ OycZr2G1D3k0t8bO2PtKD10AXA3CV6O0REVsy/6l511BgrfnQNaEgAEDaPdZnBswjrjUrZNpfx2zq mZDDTcEOB8ZcjN9kYCcshCfk6ImtOT+8CKKMTJA4Ymk9ZqVM1zLPbEwODC4uQw6Pzqgf6t0BcQ5ch AfCNfpCib7Qg4pQK5gqYwT9s+dWeo62ICcHixwIYU/Keq/lX8tq9GOl8vesp0Y3v1CRpcfAe9jrUe +nSjTDtE9OQPsaT4zMqT0LwnehHf7X3j1QUhiu6//p0oGeXlLojoAGGXJpa6edf/wHAdzkBZ/DR+P 3wBNHHnoFrCYW5T6TCc04IOsEh3eXH0WL12ViP3Fs=; Received: from [2a02:8012:2f01:0:521c:3ef:78b8:2419] by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1vCNXO-000BMu-GV; Fri, 24 Oct 2025 20:33:26 +0100 Message-ID: <1dec89c3-1ea2-43db-b9f7-5683ff18f88d@ilande.co.uk> Date: Fri, 24 Oct 2025 20:35:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org, Paolo Bonzini , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost References: <20251024190416.8803-1-philmd@linaro.org> <20251024190416.8803-2-philmd@linaro.org> Content-Language: en-US From: Mark Cave-Ayland Autocrypt: addr=mark.cave-ayland@ilande.co.uk; keydata= xsBNBFQJuzwBCADAYvxrwUh1p/PvUlNFwKosVtVHHplgWi5p29t58QlOUkceZG0DBYSNqk93 3JzBTbtd4JfFcSupo6MNNOrCzdCbCjZ64ik8ycaUOSzK2tKbeQLEXzXoaDL1Y7vuVO7nL9bG E5Ru3wkhCFc7SkoypIoAUqz8EtiB6T89/D9TDEyjdXUacc53R5gu8wEWiMg5MQQuGwzbQy9n PFI+mXC7AaEUqBVc2lBQVpAYXkN0EyqNNT12UfDLdxaxaFpUAE2pCa2LTyo5vn5hEW+i3VdN PkmjyPvL6DdY03fvC01PyY8zaw+UI94QqjlrDisHpUH40IUPpC/NB0LwzL2aQOMkzT2NABEB AAHNME1hcmsgQ2F2ZS1BeWxhbmQgPG1hcmsuY2F2ZS1heWxhbmRAaWxhbmRlLmNvLnVrPsLA eAQTAQIAIgUCVAm7PAIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQW8LFb64PMh9f NAgAuc3ObOEY8NbZko72AGrg2tWKdybcMVITxmcor4hb9155o/OWcA4IDbeATR6cfiDL/oxU mcmtXVgPqOwtW3NYAKr5g/FrZZ3uluQ2mtNYAyTFeALy8YF7N3yhs7LOcpbFP7tEbkSzoXNG z8iYMiYtKwttt40WaheWuRs0ZOLbs6yoczZBDhna3Nj0LA3GpeJKlaV03O4umjKJgACP1c/q T2Pkg+FCBHHFP454+waqojHp4OCBo6HyK+8I4wJRa9Z0EFqXIu8lTDYoggeX0Xd6bWeCFHK3 DhD0/Xi/kegSW33unsp8oVcM4kcFxTkpBgj39dB4KwAUznhTJR0zUHf63M7ATQRUCbs8AQgA y7kyevA4bpetM/EjtuqQX4U05MBhEz/2SFkX6IaGtTG2NNw5wbcAfhOIuNNBYbw6ExuaJ3um 2uLseHnudmvN4VSJ5Hfbd8rhqoMmmO71szgT/ZD9MEe2KHzBdmhmhxJdp+zQNivy215j6H27 14mbC2dia7ktwP1rxPIX1OOfQwPuqlkmYPuVwZP19S4EYnCELOrnJ0m56tZLn5Zj+1jZX9Co YbNLMa28qsktYJ4oU4jtn6V79H+/zpERZAHmH40IRXdR3hA+Ye7iC/ZpWzT2VSDlPbGY9Yja Sp7w2347L5G+LLbAfaVoejHlfy/msPeehUcuKjAdBLoEhSPYzzdvEQARAQABwsBfBBgBAgAJ BQJUCbs8AhsMAAoJEFvCxW+uDzIfabYIAJXmBepHJpvCPiMNEQJNJ2ZSzSjhic84LTMWMbJ+ opQgr5cb8SPQyyb508fc8b4uD8ejlF/cdbbBNktp3BXsHlO5BrmcABgxSP8HYYNsX0n9kERv NMToU0oiBuAaX7O/0K9+BW+3+PGMwiu5ml0cwDqljxfVN0dUBZnQ8kZpLsY+WDrIHmQWjtH+ Ir6VauZs5Gp25XLrL6bh/SL8aK0BX6y79m5nhfKI1/6qtzHAjtMAjqy8ChPvOqVVVqmGUzFg KPsrrIoklWcYHXPyMLj9afispPVR8e0tMKvxzFBWzrWX1mzljbBlnV2n8BIwVXWNbgwpHSsj imgcU9TTGC5qd9g= In-Reply-To: <20251024190416.8803-2-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a02:8012:2f01:0:521c:3ef:78b8:2419 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 01/27] hw/qdev: Have qdev_get_gpio_out_connector() take const DeviceState arg X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 24/10/2025 20:03, Philippe Mathieu-Daudé wrote: > This getter doesn't update any DeviceState internal fields, > make it const. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/qdev-core.h | 3 ++- > hw/core/gpio.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index a7bfb10dc70..2caa0cbd26f 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -725,7 +725,8 @@ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, > * > * Return: qemu_irq associated with GPIO or NULL if un-wired. > */ > -qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, int n); > +qemu_irq qdev_get_gpio_out_connector(const DeviceState *dev, > + const char *name, int n); > > /** > * qdev_intercept_gpio_out: Intercept an existing GPIO connection > diff --git a/hw/core/gpio.c b/hw/core/gpio.c > index 6e32a8eec61..c7c2936fc55 100644 > --- a/hw/core/gpio.c > +++ b/hw/core/gpio.c > @@ -129,7 +129,8 @@ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, > g_free(propname); > } > > -qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, int n) > +qemu_irq qdev_get_gpio_out_connector(const DeviceState *dev, > + const char *name, int n) > { > g_autofree char *propname = g_strdup_printf("%s[%d]", > name ? name : "unnamed-gpio-out", n); Reviewed-by: Mark Cave-Ayland ATB, Mark.