From: Aditya Gupta <adityag@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH v5 7/8] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine
Date: Mon, 24 Mar 2025 14:08:25 +0530 [thread overview]
Message-ID: <1df64072-b054-4c8e-b426-12f1ad76b550@linux.ibm.com> (raw)
In-Reply-To: <a724951a-738c-403d-8d47-8d3b83c68e13@kaod.org>
On 24/03/25 13:05, Cédric Le Goater wrote:
> On 3/24/25 08:13, Aditya Gupta wrote:
>> Hi Cedric,
>>
>> <...snip...>
>>
>> When I do this, every function using Pnv10Chip* will need to be
>> duplicated to use Pnv11Chip*.
>>
>> I will do that.
>>
>> But what do you say about changing Pnv10 chip to Pnv1x chip ? It may
>> only be used by Pnv10 and Pnv11, not future chips. But is that
>> unnecessary for just two versions of the chip ?
>>
>> Just tried to think of some ways to reduce duplication, or having
>> different files such as pnv10.c, pnv11.c ? I am not sure because
>> these might be unnecessary things too.
>
> Please open code (and duplicate) first. Then we will see how we
> can make things common. Checking the typename in the instance_init
> handleris a hack not for upstream.
Sure Cedric, will duplicate it then.
Thanks,
- Aditya Gupta
>
> Thanks,
>
> C.
>
>
next prev parent reply other threads:[~2025-03-24 8:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 20:51 [PATCH v5 0/8] Power11 support for QEMU [PowerNV] Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 1/8] ppc/pnv: Add HOMER for POWER11 Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 2/8] ppc/pnv: Add a LPC controller " Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 3/8] ppc/pnv: Add OCC for Power11 Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 4/8] ppc/pnv: Add a PSI bridge model " Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 5/8] ppc/pnv: Add SBE " Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 6/8] ppc/pnv: Add ChipTOD " Aditya Gupta
2025-03-08 20:51 ` [PATCH v5 7/8] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine Aditya Gupta
2025-03-09 14:08 ` Cédric Le Goater
2025-03-10 10:29 ` Aditya Gupta
2025-03-24 7:13 ` Aditya Gupta
2025-03-24 7:35 ` Cédric Le Goater
2025-03-24 8:38 ` Aditya Gupta [this message]
2025-03-08 20:51 ` [PATCH v5 8/8] ppc/pnv: Update skiboot to support Power11 Aditya Gupta
2025-03-09 14:10 ` Cédric Le Goater
2025-03-10 10:31 ` Aditya Gupta
2025-03-10 11:45 ` Cédric Le Goater
2025-03-10 14:59 ` Aditya Gupta
2025-03-10 15:33 ` Cédric Le Goater
2025-03-11 8:39 ` Nicholas Piggin
2025-03-11 8:46 ` Cédric Le Goater
2025-03-11 8:50 ` Aditya Gupta
2025-03-24 7:41 ` [PATCH v5 0/8] Power11 support for QEMU [PowerNV] Cédric Le Goater
2025-03-25 11:28 ` Aditya Gupta
2025-03-25 12:07 ` Cédric Le Goater
2025-03-25 17:11 ` Aditya Gupta
2025-03-25 17:16 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1df64072-b054-4c8e-b426-12f1ad76b550@linux.ibm.com \
--to=adityag@linux.ibm.com \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).