From: David Hildenbrand <david@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH v1] qapi: document parameters of query-cpu-model-* QAPI commands
Date: Mon, 25 Mar 2024 17:27:28 +0100 [thread overview]
Message-ID: <1e03601d-f55d-4527-8382-d884d226bd50@redhat.com> (raw)
In-Reply-To: <87edbyjp0x.fsf@pond.sub.org>
>> #
>> # Usually, a CPU model is compared against the maximum possible CPU
>> # model of a certain configuration (e.g. the "host" model for KVM).
>> @@ -154,7 +155,14 @@
>> # Some architectures may not support comparing CPU models. s390x
>> # supports comparing CPU models.
>> #
>> -# Returns: a CpuModelBaselineInfo
>> +# @modela: description of the first CPU model to compare, referred to as
>> +# "model A" in CpuModelCompareResult
>> +#
>> +# @modelb: description of the second CPU model to compare, referred to as
>> +# "model B" in CpuModelCompareResult
>> +#
>> +# Returns: a CpuModelCompareInfo, describing how both CPU models
>
> Scratch the comma?
Agreed to both. Do you want to fixup when applying or do you prefer a v2?
Thanks!
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-03-25 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 15:01 [PATCH v1] qapi: document parameters of query-cpu-model-* QAPI commands David Hildenbrand
2024-03-25 15:43 ` Markus Armbruster
2024-03-25 16:27 ` David Hildenbrand [this message]
2024-03-25 17:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e03601d-f55d-4527-8382-d884d226bd50@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).