From: Richard Henderson <richard.henderson@linaro.org>
To: Milica Lazarevic <milica.lazarevic@syrmia.com>, thuth@redhat.com
Cc: qemu-devel@nongnu.org, cfontana@suse.de, berrange@redhat.com,
pbonzini@redhat.com, vince.delvecchio@mediatek.com,
peter.maydell@linaro.org, djordje.todorovic@syrmia.com,
mips32r2@gmail.com, dragan.mladjenovic@syrmia.com
Subject: Re: [PATCH v2 11/20] disas/nanomips: Remove #inlcude <sstream>
Date: Mon, 5 Sep 2022 12:14:49 +0100 [thread overview]
Message-ID: <1e073a1b-c470-db73-d245-d9faae29f0b2@linaro.org> (raw)
In-Reply-To: <20220905095522.66941-12-milica.lazarevic@syrmia.com>
On 9/5/22 10:55, Milica Lazarevic wrote:
> <sstream> is a C++ library and it's not used by disassembler.
>
> Signed-off-by: Milica Lazarevic<milica.lazarevic@syrmia.com>
> Reviewed-by: Thomas Huth<thuth@redhat.com>
> ---
> disas/nanomips.cpp | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-09-05 11:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 9:55 [PATCH v2 0/20] Convert nanoMIPS disassembler from C++ to C Milica Lazarevic
2022-09-05 9:55 ` [PATCH v2 01/20] disas/nanomips: Remove namespace img Milica Lazarevic
2022-09-05 11:00 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 02/20] disas/nanomips: Extract enums out of the NMD class Milica Lazarevic
2022-09-05 11:00 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 03/20] disas/nanomips: Delete NMD class fields Milica Lazarevic
2022-09-05 11:04 ` Richard Henderson
2022-09-05 11:53 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 04/20] disas/nanomips: Remove helper methods from class Milica Lazarevic
2022-09-05 11:05 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 05/20] disas/nanomips: Remove __cond " Milica Lazarevic
2022-09-05 11:06 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 06/20] disas/nanomips: Remove disasm " Milica Lazarevic
2022-09-05 11:08 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 07/20] disas/nanomips: Remove Pool tables from the class Milica Lazarevic
2022-09-05 11:11 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 08/20] disas/nanomips: Remove NMD class Milica Lazarevic
2022-09-05 11:13 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 09/20] disas/nanomips: Move typedefs etc to nanomips.cpp Milica Lazarevic
2022-09-05 11:14 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 10/20] disas/nanomips: Delete nanomips.h Milica Lazarevic
2022-09-05 11:14 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 11/20] disas/nanomips: Remove #inlcude <sstream> Milica Lazarevic
2022-09-05 11:14 ` Richard Henderson [this message]
2022-09-05 9:55 ` [PATCH v2 12/20] disas/nanomips: Replace std::string type Milica Lazarevic
2022-09-05 11:32 ` Richard Henderson
2022-09-08 19:16 ` Milica Lazarevic
2022-09-08 21:14 ` Richard Henderson
2022-09-08 21:46 ` Milica Lazarevic
2022-09-05 9:55 ` [PATCH v2 13/20] disas/nanomips: Prevent memory leaking Milica Lazarevic
2022-09-05 11:41 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 14/20] disas/nanomips: Remove function overloading Milica Lazarevic
2022-09-05 11:43 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 15/20] disas/nanomips: Introduce Dis_info struct Milica Lazarevic
2022-09-05 11:55 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 16/20] disas/nanomips: Replace exception handling Milica Lazarevic
2022-09-05 11:50 ` Richard Henderson
2022-09-07 17:09 ` Milica Lazarevic
2022-09-05 9:55 ` [PATCH v2 17/20] disas/nanomips: Replace Cpp enums for C enums Milica Lazarevic
2022-09-05 11:47 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 18/20] disas/nanomips: Remove argument passing by ref Milica Lazarevic
2022-09-05 11:56 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 19/20] disas/nanomips: Add struct keyword Milica Lazarevic
2022-09-05 11:57 ` Richard Henderson
2022-09-05 9:55 ` [PATCH v2 20/20] disas/nanomips: Rename nanomips.cpp to nanomips.c Milica Lazarevic
2022-09-05 11:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e073a1b-c470-db73-d245-d9faae29f0b2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=djordje.todorovic@syrmia.com \
--cc=dragan.mladjenovic@syrmia.com \
--cc=milica.lazarevic@syrmia.com \
--cc=mips32r2@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vince.delvecchio@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).