From: Jason Wang <jasowang@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: Mike Nawrocki <michael.nawrocki@gtri.gatech.edu>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a
Date: Wed, 15 Nov 2017 19:22:32 +0800 [thread overview]
Message-ID: <1e12f490-54b5-8739-df63-db260248e048@redhat.com> (raw)
In-Reply-To: <e84e4b9f-8a88-5c68-8440-96df5bef1ad5@weilnetz.de>
On 2017年11月15日 14:43, Stefan Weil wrote:
> Hi,
>
> I currently think that this patch is wrong and should be reverted.
>
> It fixes a certain use case by hacking the PCI device id, but does
> not model the way how that device id is set on the real hardware
> correctly.
>
> As far as I know, all i82559 have a default PCI device id of 0x1229.
> It can be changed by the EEPROM configuration, but not all network
> cards do have an EEPROM.
>
> See for example this URL for more information:
> http://zoo.cs.yale.edu/classes/cs422/2010/ref/82559_eeprom.pdf
>
> The correct solution is modeling the EEPROM and allowing QEMU
> users to provide an EEPROM file.
Yes and unless there's new version of sepc that has different ID, I tend
to revert this.
Thanks
>
> Cheers
> Stefan
next prev parent reply other threads:[~2017-11-15 11:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 2:11 [Qemu-devel] [PULL 0/8] Net patches Jason Wang
2017-11-14 2:11 ` [Qemu-devel] [PULL 1/8] net: fix check for number of parameters to -netdev socket Jason Wang
2017-11-14 2:11 ` [Qemu-devel] [PULL 2/8] colo-compare: Insert packet into the suitable position of packet queue directly Jason Wang
2017-11-14 2:11 ` [Qemu-devel] [PULL 3/8] colo-compare: compare the packet in a specified Connection Jason Wang
2017-11-15 18:57 ` Peter Maydell
2017-11-16 1:32 ` Mao Zhongyi
2017-11-14 2:11 ` [Qemu-devel] [PULL 4/8] colo-compare: Fix comments Jason Wang
2017-11-14 2:11 ` [Qemu-devel] [PULL 5/8] colo: Consolidate the duplicate code chunk into a routine Jason Wang
2017-11-14 2:11 ` [Qemu-devel] [PULL 6/8] Fix eepro100 simple transmission mode Jason Wang
2017-11-14 2:11 ` [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a Jason Wang
2017-11-15 6:43 ` Stefan Weil
2017-11-15 11:22 ` Jason Wang [this message]
2017-11-14 2:11 ` [Qemu-devel] [PULL 8/8] net/socket: fix coverity issue Jason Wang
2017-11-14 15:23 ` [Qemu-devel] [PULL 0/8] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e12f490-54b5-8739-df63-db260248e048@redhat.com \
--to=jasowang@redhat.com \
--cc=michael.nawrocki@gtri.gatech.edu \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).