From: Laurent Vivier <laurent@vivier.eu>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno
Date: Tue, 8 May 2018 22:26:44 +0200 [thread overview]
Message-ID: <1e171cf8-e708-d2cf-5ec4-5b7b6e3b1910@vivier.eu> (raw)
In-Reply-To: <CAMo8BfJv_Sg8EhjrUcS-wjbwwiLgv2kY4-GaxtXTygs19hUMqQ@mail.gmail.com>
Le 08/05/2018 à 22:22, Max Filippov a écrit :
> On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>> Copied from linux/arch/sparc/include/uapi/asm/errno.h
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> linux-user/sparc/target_syscall.h | 203 ++++++++++++++++++++++++++++++++++++
>> linux-user/sparc64/target_syscall.h | 203 ++++++++++++++++++++++++++++++++++++
>> 2 files changed, 406 insertions(+)
>
> The changes are coming from single file, why duplicating them?
> Could they go into e.g. linux-user/sparc/target_errno.h, and get
> #included by both linux-user/sparc/target_syscall.h and
> linux-user/sparc64/target_syscall.h?
>
Yes, I was also thinking at something like that.
I did like that because in QEMU sparc and sparc64 use two different
directories whereas in linux they use the same one. Duplication seems to
be the rule...
I will do as you suggest in v2 of the series.
Thanks,
Laurent
prev parent reply other threads:[~2018-05-08 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 19:40 [Qemu-devel] [PATCH 0/5] linux-user: fix sparc32plus Laurent Vivier
2018-05-08 19:40 ` [Qemu-devel] [PATCH 1/5] linux-user: define correct fcntl() values for sparc Laurent Vivier
2018-05-08 20:01 ` Max Filippov
2018-05-08 19:40 ` [Qemu-devel] [PATCH 2/5] linux-user: fix flock/flock64 padding Laurent Vivier
2018-05-08 20:08 ` Max Filippov
2018-05-08 19:40 ` [Qemu-devel] [PATCH 3/5] linux-user: update sparc/syscall_nr.h to linux header 4.16 Laurent Vivier
2018-05-08 19:40 ` [Qemu-devel] [PATCH 4/5] linux-user: fix convertion of flock/flock64 l_type field Laurent Vivier
2018-05-08 19:40 ` [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno Laurent Vivier
2018-05-08 20:22 ` Max Filippov
2018-05-08 20:26 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e171cf8-e708-d2cf-5ec4-5b7b6e3b1910@vivier.eu \
--to=laurent@vivier.eu \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).