From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gB26f-0005X2-Lb for qemu-devel@nongnu.org; Fri, 12 Oct 2018 14:24:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gB26c-0006Pn-Fg for qemu-devel@nongnu.org; Fri, 12 Oct 2018 14:24:13 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:32786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gB26c-0006PM-8r for qemu-devel@nongnu.org; Fri, 12 Oct 2018 14:24:10 -0400 Received: by mail-pf1-x42d.google.com with SMTP id 78-v6so4219348pfq.0 for ; Fri, 12 Oct 2018 11:24:10 -0700 (PDT) References: <20181012173047.25420-1-kbastian@mail.uni-paderborn.de> <20181012173047.25420-4-kbastian@mail.uni-paderborn.de> From: Richard Henderson Message-ID: <1e2858da-02c6-177b-0340-39d02ef9f75b@linaro.org> Date: Fri, 12 Oct 2018 11:24:05 -0700 MIME-Version: 1.0 In-Reply-To: <20181012173047.25420-4-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store insns to decodetree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , mjc@sifive.com, palmer@sifive.com, sagark@eecs.berkeley.edu Cc: peer.adelt@hni.uni-paderborn.de, Alistair.Francis@wdc.com, qemu-devel@nongnu.org On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > +} > +static bool trans_lh(DisasContext *ctx, arg_lh *a, uint32_t insn) Watch your spacing. Otherwise, Reviewed-by: Richard Henderson r~