From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, qemu-block@nongnu.org
Subject: Re: [PATCH v3 2/3] async: always set ctx->notified in aio_notify()
Date: Thu, 6 Aug 2020 15:45:33 +0200 [thread overview]
Message-ID: <1e47af10-47fb-0a2f-7aa2-8a426ec86361@redhat.com> (raw)
In-Reply-To: <20200806131802.569478-3-stefanha@redhat.com>
On 06/08/20 15:18, Stefan Hajnoczi wrote:
> + atomic_set(&ctx->notified, false);
> +
> + /*
> + * Write ctx->notified before reading e.g. bh->flags. Pairs with smp_mb in
> + * aio_notify.
> + */
> + smp_wmb();
Sorry I was not clear: the memory barrier has to be smp_mb(), but the
comment has to say smp_wmb(). No need to repost for this.
Paolo
next prev parent reply other threads:[~2020-08-06 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:17 [PATCH v3 0/3] aio-posix: keep aio_notify_me disabled during polling Stefan Hajnoczi
2020-08-06 13:18 ` [PATCH v3 1/3] async: rename event_notifier_dummy_cb/poll() Stefan Hajnoczi
2020-08-06 13:18 ` [PATCH v3 2/3] async: always set ctx->notified in aio_notify() Stefan Hajnoczi
2020-08-06 13:45 ` Paolo Bonzini [this message]
2020-08-07 10:02 ` Stefan Hajnoczi
2020-08-06 13:18 ` [PATCH v3 3/3] aio-posix: keep aio_notify_me disabled during polling Stefan Hajnoczi
2020-08-06 13:47 ` [PATCH v3 0/3] " Paolo Bonzini
2020-08-13 12:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e47af10-47fb-0a2f-7aa2-8a426ec86361@redhat.com \
--to=pbonzini@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).