From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
richard.henderson@linaro.org, cota@braap.org,
Paolo Bonzini <pbonzini@redhat.com>,
aurelien@aurel32.net, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id
Date: Wed, 9 Sep 2020 14:58:14 +0200 [thread overview]
Message-ID: <1e49f739-8ce3-dc15-024c-9bf3156b0253@redhat.com> (raw)
In-Reply-To: <20200909112742.25730-8-alex.bennee@linaro.org>
On 9/9/20 1:27 PM, Alex Bennée wrote:
> Some compilers (notably the Xenial gcc in Travis) fail to spot that
> this will always be set if pch_dev_id != 0xffff. Given this is setup
> code and using _Pragma to override is equally as ugly lets just remove
> the doubt from the compilers mind.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/i386/pc_piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 32b1453e6a8..33fa035fb7f 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -930,7 +930,7 @@ void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id)
> struct PCIDevice *bridge_dev;
> int i, num;
> uint16_t pch_dev_id = 0xffff;
> - uint8_t pch_rev_id;
> + uint8_t pch_rev_id = 0;
>
> num = ARRAY_SIZE(igd_combo_id_infos);
> for (i = 0; i < num; i++) {
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-09-09 12:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 11:27 [PATCH v2 00/10] testing and misc updates Alex Bennée
2020-09-09 11:27 ` [PATCH v2 01/10] CODING_STYLE.rst: flesh out our naming conventions Alex Bennée
2020-09-09 13:44 ` Thomas Huth
2020-09-09 11:27 ` [PATCH v2 02/10] usb-host: restrict workaround to new libusb versions Alex Bennée
2020-09-09 11:27 ` [PATCH v2 03/10] tests/meson.build: fp tests don't need CONFIG_TCG Alex Bennée
2020-09-09 13:03 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 04/10] target/mips: simplify gen_compute_imm_branch logic Alex Bennée
2020-09-09 11:27 ` [PATCH v2 05/10] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation Alex Bennée
2020-09-09 12:59 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 06/10] configure: don't enable ppc64abi32-linux-user by default Alex Bennée
2020-09-09 12:57 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id Alex Bennée
2020-09-09 12:58 ` Philippe Mathieu-Daudé [this message]
2020-09-09 11:27 ` [PATCH v2 08/10] tests: bump avocado version Alex Bennée
2020-09-09 11:27 ` [PATCH v2 09/10] tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True) Alex Bennée
2020-09-09 11:27 ` [PATCH v2 10/10] plugins: move the more involved plugins to contrib Alex Bennée
2020-09-09 13:57 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e49f739-8ce3-dc15-024c-9bf3156b0253@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).