From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D76C433E2 for ; Wed, 9 Sep 2020 12:59:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE46B21941 for ; Wed, 9 Sep 2020 12:59:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eaA9LbYT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE46B21941 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFzgt-0008OR-TQ for qemu-devel@archiver.kernel.org; Wed, 09 Sep 2020 08:59:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFzg7-0007GK-Hn for qemu-devel@nongnu.org; Wed, 09 Sep 2020 08:58:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFzg5-0001Jy-Eu for qemu-devel@nongnu.org; Wed, 09 Sep 2020 08:58:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599656300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=btRTboAhnb3CFJTYZPAyzn+Y5fOVx3YbOUqJlxfBFi4=; b=eaA9LbYTuplnju+TBKUK4P5cRGzopBq1rrrWPEMlSdg7WXj1XhACM1SfeyBmQMfqAQJd7E 1EHE4zYayyHTsPQ8pulM7AmiCACNkXRKXN9Hcekvgxgzm+IDM/8Wd97OKxNamFuAcbXK2z XX7gLhs7jYorxqMOrBpLTXZoGVglzEA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-liG6UAvEPGyDC4rm0GDZNQ-1; Wed, 09 Sep 2020 08:58:18 -0400 X-MC-Unique: liG6UAvEPGyDC4rm0GDZNQ-1 Received: by mail-wm1-f69.google.com with SMTP id k12so743895wmj.1 for ; Wed, 09 Sep 2020 05:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=btRTboAhnb3CFJTYZPAyzn+Y5fOVx3YbOUqJlxfBFi4=; b=p1DDLCR/NkSOPLQKX3QZtBcJZA/uz2bJcymBhCxioZbvPRlWSM4bvyxRqYByJGh2vI DUWeNjuhuqCd8myXJijQL9ahOmBWbQA3c2cPoinKbOMotgMee0Qsxu7+jFXnHRjhAutV ihhik/JOEG1m/or9+jxIji9q/dGhJE4a42sAV6OunxZPkWH7XyguEC0QYk0anihjzx3r TMbgXbZD3l8olRvlD0DmjuihDXFve3qGNqGsHmmIYXf/YMd4P3nHDZ07xUEO5TMd5G96 KI2sszpOyyWnn9Z4LB9B59VKC1qaqpHB0CdZ46aQ9LEbfT3DN7ethoSa9ASJA2/Q0HEK 5R/g== X-Gm-Message-State: AOAM533pZ1nXD4riX9b2Axg3Ilwyc7zOhIagFa1rUfmmKH6T6qIhMa2f gvs2O/+JltrjMPQ6VRLUDIj8EYqg+vPCfQ7yxHukGof232rpjorI9sEPLyo2Q/dS1B2D7BpTzrB fO3R2x6gEjCbcBRE= X-Received: by 2002:a7b:cb81:: with SMTP id m1mr3653090wmi.140.1599656296235; Wed, 09 Sep 2020 05:58:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPETotoyuzkE6/AQF5N4tixsnfcOkvxXjMRaaKcVq+eZ5jA6PuddUmDU+nUbgxPpalplSZNA== X-Received: by 2002:a7b:cb81:: with SMTP id m1mr3653070wmi.140.1599656296023; Wed, 09 Sep 2020 05:58:16 -0700 (PDT) Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id 5sm3875527wmz.22.2020.09.09.05.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 05:58:15 -0700 (PDT) Subject: Re: [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20200909112742.25730-1-alex.bennee@linaro.org> <20200909112742.25730-8-alex.bennee@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <1e49f739-8ce3-dc15-024c-9bf3156b0253@redhat.com> Date: Wed, 9 Sep 2020 14:58:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200909112742.25730-8-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 03:25:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.576, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Eduardo Habkost , "Michael S. Tsirkin" , richard.henderson@linaro.org, cota@braap.org, Paolo Bonzini , aurelien@aurel32.net, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/9/20 1:27 PM, Alex Bennée wrote: > Some compilers (notably the Xenial gcc in Travis) fail to spot that > this will always be set if pch_dev_id != 0xffff. Given this is setup > code and using _Pragma to override is equally as ugly lets just remove > the doubt from the compilers mind. > > Signed-off-by: Alex Bennée > --- > hw/i386/pc_piix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 32b1453e6a8..33fa035fb7f 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -930,7 +930,7 @@ void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id) > struct PCIDevice *bridge_dev; > int i, num; > uint16_t pch_dev_id = 0xffff; > - uint8_t pch_rev_id; > + uint8_t pch_rev_id = 0; > > num = ARRAY_SIZE(igd_combo_id_infos); > for (i = 0; i < num; i++) { > Reviewed-by: Philippe Mathieu-Daudé