From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] block: make bdrv_drop_intermediate() less wrong
Date: Thu, 5 Nov 2020 14:24:02 +0100 [thread overview]
Message-ID: <1e4a2227-3557-4b3f-5aab-5aa8c98cc0ac@redhat.com> (raw)
In-Reply-To: <384f5bfc-238e-6b7f-473b-6aa5cd93ef52@redhat.com>
On 05.11.20 14:22, Max Reitz wrote:
> On 31.10.20 13:35, Vladimir Sementsov-Ogievskiy wrote:
>> First, permission update loop tries to do iterations transactionally,
>> but the whole update is not transactional: nobody roll-back successful
>> loop iterations when some iteration fails.
[...]
> And besides rolling back on error, we don’t commit on success either.
(Oh, we do, through bdrv_replace_child(). Well.)
Max
next prev parent reply other threads:[~2020-11-05 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 12:35 [PATCH 0/2] Fix nested permission update Vladimir Sementsov-Ogievskiy
2020-10-31 12:35 ` [PATCH 1/2] block: make bdrv_drop_intermediate() less wrong Vladimir Sementsov-Ogievskiy
2020-11-05 13:22 ` Max Reitz
2020-11-05 13:24 ` Max Reitz [this message]
2020-11-05 15:03 ` Alberto Garcia
2020-11-05 15:14 ` Alberto Garcia
2020-11-06 9:26 ` Vladimir Sementsov-Ogievskiy
2020-10-31 12:35 ` [PATCH 2/2] block: assert that permission commit sets same permissions Vladimir Sementsov-Ogievskiy
2020-10-31 13:23 ` Vladimir Sementsov-Ogievskiy
2020-11-05 14:34 ` Max Reitz
-- strict thread matches above, loose matches on Subject: below --
2020-11-23 20:12 [PATCH RFC 00/21] block: update graph permissions update Vladimir Sementsov-Ogievskiy
2020-11-23 20:12 ` [PATCH 1/2] block: make bdrv_drop_intermediate() less wrong Vladimir Sementsov-Ogievskiy
2020-11-24 9:39 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e4a2227-3557-4b3f-5aab-5aa8c98cc0ac@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).