From: Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: eblake@redhat.com
Subject: Re: [PATCH v2 for-7.1 2/9] nbd: mark more coroutine_fns
Date: Fri, 15 Apr 2022 13:12:53 +0300 [thread overview]
Message-ID: <1e61b9bf-25e6-f874-21cf-e3a75fb6511a@mail.ru> (raw)
In-Reply-To: <20220414175756.671165-3-pbonzini@redhat.com>
14.04.2022 20:57, Paolo Bonzini wrote:
> Several coroutine functions in block/nbd.c are not marked as such. This
> patch adds a few more markers; it is not exhaustive, but it focuses
> especially on:
>
> - places that wake other coroutines, because aio_co_wake() has very
> different semantics inside a coroutine (queuing after yield vs. entering
> immediately);
>
> - functions with_co_ in their names, to avoid confusion
>
> Reviewed-by: Eric Blake<eblake@redhat.com>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
nbd_reply_chunk_iter_receive is forgotten :)
Also, many function headers becomes >80 character length, checkpatch should complain.
That all is not critical and may be fixed by follow-up.
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2022-04-15 10:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 17:57 [PATCH v2 for-7.1 0/9] nbd: actually make s->state thread-safe Paolo Bonzini
2022-04-14 17:57 ` [PATCH v2 for-7.1 1/9] nbd: safeguard against waking up invalid coroutine Paolo Bonzini
2022-04-14 19:02 ` Eric Blake
2022-04-15 9:53 ` Vladimir Sementsov-Ogievskiy
2022-04-14 17:57 ` [PATCH v2 for-7.1 2/9] nbd: mark more coroutine_fns Paolo Bonzini
2022-04-15 10:12 ` Vladimir Sementsov-Ogievskiy [this message]
2022-04-14 17:57 ` [PATCH v2 for-7.1 3/9] nbd: remove peppering of nbd_client_connected Paolo Bonzini
2022-04-15 17:01 ` Vladimir Sementsov-Ogievskiy
2022-04-23 8:30 ` Paolo Bonzini
2022-04-14 17:57 ` [PATCH v2 for-7.1 4/9] nbd: keep send_mutex/free_sema handling outside nbd_co_do_establish_connection Paolo Bonzini
2022-04-14 19:11 ` Eric Blake
2022-04-16 11:54 ` Vladimir Sementsov-Ogievskiy
2022-04-23 8:34 ` Paolo Bonzini
2022-04-14 17:57 ` [PATCH v2 for-7.1 5/9] nbd: use a QemuMutex to synchronize yanking, reconnection and coroutines Paolo Bonzini
2022-04-14 19:33 ` Eric Blake
2022-04-16 12:18 ` Vladimir Sementsov-Ogievskiy
2022-04-23 8:37 ` Paolo Bonzini
2022-04-14 17:57 ` [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming Paolo Bonzini
2022-04-14 19:37 ` Eric Blake
2022-04-16 12:37 ` Vladimir Sementsov-Ogievskiy
2022-04-23 8:38 ` Paolo Bonzini
2022-04-14 17:57 ` [PATCH v2 for-7.1 7/9] nbd: move s->state under requests_lock Paolo Bonzini
2022-04-14 19:40 ` Eric Blake
2022-04-16 13:37 ` Vladimir Sementsov-Ogievskiy
2022-04-14 17:57 ` [PATCH v2 for-7.1 8/9] nbd: take receive_mutex when reading requests[].receiving Paolo Bonzini
2022-04-14 19:42 ` Eric Blake
2022-04-16 13:54 ` Vladimir Sementsov-Ogievskiy
2022-04-14 17:57 ` [PATCH v2 for-7.1 9/9] nbd: document what is protected by the CoMutexes Paolo Bonzini
2022-04-14 19:42 ` Eric Blake
2022-04-16 14:00 ` Vladimir Sementsov-Ogievskiy
2022-04-23 8:41 ` Paolo Bonzini
2022-04-16 19:03 ` [PATCH v2 for-7.1 0/9] nbd: actually make s->state thread-safe Lukas Straub
2022-04-22 20:39 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e61b9bf-25e6-f874-21cf-e3a75fb6511a@mail.ru \
--to=v.sementsov-og@mail.ru \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).