From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFC1C4338F for ; Tue, 27 Jul 2021 12:52:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0331E619E5 for ; Tue, 27 Jul 2021 12:52:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0331E619E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:32838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8MZI-0000Bw-83 for qemu-devel@archiver.kernel.org; Tue, 27 Jul 2021 08:52:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8MXM-0005vt-3F for qemu-devel@nongnu.org; Tue, 27 Jul 2021 08:50:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56448) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8MXI-0003rV-5S for qemu-devel@nongnu.org; Tue, 27 Jul 2021 08:50:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627390214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B1LsIJvSSFTw1m6TPHvHAGf1RSL//LJLN36euyIUmmQ=; b=Rwszyzz8xJYxHhv8d9RCw5o7I9HzXd2cdM/iKJO3JHDgGY+ozdEkZR5+gALdeoo863T96j i/0V6Htm4gRWhd9kCef0pvEm9lXduwgmhrldMPIkEahT7ZgWictpzMXL8ALxKnWucojimG ZHLLlzh6rnlAnH24shhTfB+p4HVlYUQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-MpyDMlhUPmSbSpW0KMxPng-1; Tue, 27 Jul 2021 08:50:11 -0400 X-MC-Unique: MpyDMlhUPmSbSpW0KMxPng-1 Received: by mail-wr1-f70.google.com with SMTP id v18-20020adfe2920000b029013bbfb19640so5942204wri.17 for ; Tue, 27 Jul 2021 05:50:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=B1LsIJvSSFTw1m6TPHvHAGf1RSL//LJLN36euyIUmmQ=; b=KP/g5kZcNa6StF8CEPLXrYyHsF6MFEsagKfUFVz8EJIxg1cA+X6XA4v9Mw7NB1ps2a o425NXyIpSnIg0KejtsEq6d6UB8mMsNtZyv3or1pUFgI7wNLPrWEXEZimKnD6mi37wcg BsQn1DzbGHibZ8nMGWAcV+m2UZY3gSZd9WqXuogQ3uGidPlEP+GJgesNavCO8sXbA18d BHenEG9DDXfQAxYlGkXUF2xMRsuJSlGYJU2homS0/8mIUqaS17g3NFJkTwlOkfVKFKP1 sWjNYwFkftXiFPZOZash5xTOILrKjgMswDAMnZNAJe/0cWEoZyjQPs/P2o9pmY4CmqDu gjiQ== X-Gm-Message-State: AOAM533UqeSXriUe25gwC8imp7ptphU6nuEeqvx+DN5s2LQ7BsCSmOxt X9c33piFqKyzRhZ/WVu/lL1l1kE9WwgFnXjOz3euEVhGgYPkppv79bQfk4DUb6dxpAorsI0/PZS 1mBvVFY930NLBpOE= X-Received: by 2002:a1c:2b04:: with SMTP id r4mr19291363wmr.168.1627390209807; Tue, 27 Jul 2021 05:50:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzTUSeihFgNTymVP87uiPWQVE6HjvaXth1PkKY45Kd9G6ZFME0Ks8eR1EKdMA/M7FSg6iynQ== X-Received: by 2002:a1c:2b04:: with SMTP id r4mr19291347wmr.168.1627390209619; Tue, 27 Jul 2021 05:50:09 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c36.dip0.t-ipconnect.de. [79.242.60.54]) by smtp.gmail.com with ESMTPSA id d67sm2969878wmd.9.2021.07.27.05.50.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 05:50:09 -0700 (PDT) Subject: Re: [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu() To: Peter Xu , qemu-devel@nongnu.org References: <20210723193444.133412-1-peterx@redhat.com> <20210723193444.133412-7-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <1e61bcc4-d907-5409-f85a-448761300b85@redhat.com> Date: Tue, 27 Jul 2021 14:50:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210723193444.133412-7-peterx@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.438, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23.07.21 21:34, Peter Xu wrote: > We must use the BQL for do_run_on_cpu() without much choice, it means the > parameter is helpless. Remove it. Meanwhile use the newly introduced s/helpless/useless/ ? Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb