From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Kdy-0001Ld-Hi for qemu-devel@nongnu.org; Mon, 14 Nov 2016 12:02:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6Kdt-0005RX-L5 for qemu-devel@nongnu.org; Mon, 14 Nov 2016 12:02:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38086) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6Kdt-0005RM-Dl for qemu-devel@nongnu.org; Mon, 14 Nov 2016 12:02:01 -0500 References: <147914275667.238.7399833850728779563@9040ca97f87d> From: John Snow Message-ID: <1e656ae0-e558-e096-730b-2a5853a7c935@redhat.com> Date: Mon, 14 Nov 2016 12:01:59 -0500 MIME-Version: 1.0 In-Reply-To: <147914275667.238.7399833850728779563@9040ca97f87d> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 0/9] Ide patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, peter.maydell@linaro.org On 11/14/2016 11:59 AM, no-reply@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > All failures below are intentional deviations. > Type: series > Subject: [Qemu-devel] [PULL v2 0/9] Ide patches > Message-id: 1479140746-22142-1-git-send-email-jsnow@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/1479140746-22142-1-git-send-email-jsnow@redhat.com -> patchew/1479140746-22142-1-git-send-email-jsnow@redhat.com > Switched to a new branch 'test' > aac853f ahci-test: add QMP tray test for ATAPI > 9aff593 libqos/ahci: Add get_sense and test_ready > 7163df5 libqos/ahci: Add ATAPI tray macros > f1e2266 libqos/ahci: Support expected errors > 3968b94 libqtest: add qmp_eventwait_ref > 9d13ef0 block-backend: Always notify on blk_eject > 341ba04 ahci-test: test atapi read_cd with bcl, nb_sectors = 0 > 8990ba8 ahci-test: Create smaller test ISO images > e3e34c1 atapi: classify read_cd as conditionally returning data > > === OUTPUT BEGIN === > fatal: unrecognized argument: --no-patch > Checking PATCH 1/9: ... > ERROR: space prohibited after that open square bracket '[' > #92: FILE: hw/ide/atapi.c:1324: > + [ 0xbe ] = { cmd_read_cd, CHECK_READY | CONDDATA }, > > ERROR: space prohibited before that close square bracket ']' > #92: FILE: hw/ide/atapi.c:1324: > + [ 0xbe ] = { cmd_read_cd, CHECK_READY | CONDDATA }, > > total: 2 errors, 0 warnings, 86 lines checked > This is intentional and won't change, at least not for this patch. If we truly want to restructure the command table, I can -- but another time. --js > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > fatal: unrecognized argument: --no-patch > Checking PATCH 2/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 3/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 4/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 5/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 6/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 7/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 8/9: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 9/9: ... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org >