From: Eric Blake <eblake@redhat.com>
To: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Brad Smith" <brad@comstyle.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Kamil Rytarowski" <kamil@netbsd.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 02/18] configure: Disable W^X on OpenBSD
Date: Mon, 4 Feb 2019 21:04:30 -0600 [thread overview]
Message-ID: <1e67828c-3f62-da8f-f615-259f721a4bba@redhat.com> (raw)
In-Reply-To: <0462853c-2f19-58ff-aee5-d667a86322e1@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On 1/30/19 1:17 AM, Thomas Huth wrote:
>> test ... -a ...
>>
>> is not portable (POSIX permits non-XSI systems to omit support for these
>> operators, but even where they are supported, there are some inherently
>> ambiguous inputs where you CANNOT predict whether the shell will parse
>> -a as a binary operator or as an argument to some other operator).
>> Instead, you should ALWAYS break dual tests into:
>>
>> test ... && test ...
>>
>> instead. (Same for '-o' vs '|| test')
>
> $ grep 'test.* -a ' configure | wc -l
> 21
> $ grep 'test.* && ' configure | wc -l
> 16
>
> Looks like we do not really care?
Well, I care. Enough to propose a patch :)
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00960.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-05 3:17 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 17:53 [Qemu-devel] [PATCH v2 00/18] OpenBSD: Enable qtesting Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 01/18] tests/vm: Be verbose while extracting compressed images Philippe Mathieu-Daudé
2019-02-05 13:17 ` Peter Maydell
2019-02-07 22:08 ` Philippe Mathieu-Daudé
2019-02-08 17:36 ` Alex Bennée
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 02/18] configure: Disable W^X on OpenBSD Philippe Mathieu-Daudé
2019-01-29 18:02 ` Philippe Mathieu-Daudé
2019-01-29 21:54 ` Eric Blake
2019-01-30 7:17 ` Thomas Huth
2019-02-05 3:04 ` Eric Blake [this message]
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 03/18] tests/vm/openbsd: Disable the W^X protection on the build partition Philippe Mathieu-Daudé
2019-01-29 21:58 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 04/18] ahci-test: Add dependency to qemu-img tool Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 05/18] qemu-iotests: Add dependency to qemu-nbd tool Philippe Mathieu-Daudé
2019-01-29 22:03 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 06/18] qemu-iotests: Improve portability by searching bash in the $PATH Philippe Mathieu-Daudé
2019-01-29 22:15 ` Eric Blake
2019-01-30 10:11 ` Thomas Huth
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 07/18] tests/multiboot: " Philippe Mathieu-Daudé
2019-01-29 18:10 ` Kamil Rytarowski
2019-01-29 22:16 ` Eric Blake
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 08/18] tests/bios-tables: " Philippe Mathieu-Daudé
2019-01-29 18:12 ` Kamil Rytarowski
2019-01-30 8:30 ` Igor Mammedov
2019-02-20 20:01 ` Michael S. Tsirkin
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports Philippe Mathieu-Daudé
2019-02-05 13:20 ` Peter Maydell
2019-02-05 13:42 ` Philippe Mathieu-Daudé
2019-02-05 13:57 ` Brad Smith
2019-02-05 14:23 ` Philippe Mathieu-Daudé
2019-02-05 22:24 ` Brad Smith
2019-02-06 9:17 ` Daniel P. Berrangé
2019-02-06 7:29 ` Gerd Hoffmann
2019-02-06 12:11 ` Peter Maydell
2019-02-06 18:15 ` Brad Smith
2019-02-06 20:25 ` Alex Bennée
2019-02-07 1:03 ` Brad Smith
2019-02-07 7:59 ` Alex Bennée
2019-02-05 16:09 ` Alex Bennée
2019-02-05 16:17 ` Daniel P. Berrangé
2019-01-29 17:53 ` [Qemu-devel] [RFC PATCH v2 10/18] qemu-iotests: Ensure GNU sed is used Philippe Mathieu-Daudé
2019-01-29 22:21 ` Eric Blake
2019-02-04 23:55 ` Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 11/18] tests/vm/openbsd: Install GNU sed from the ports Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [RFC PATCH v2 12/18] test-iov: Disable iov/io test on OpenBSD Philippe Mathieu-Daudé
2019-01-29 17:53 ` [Qemu-devel] [RFC PATCH v2 13/18] oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure Philippe Mathieu-Daudé
2019-02-05 13:22 ` Peter Maydell
2019-02-05 13:43 ` Philippe Mathieu-Daudé
2019-02-05 17:40 ` Michael S. Tsirkin
2019-01-29 17:53 ` [Qemu-devel] [PATCH v2 14/18] tests/vm: Run tests on OpenBSD Philippe Mathieu-Daudé
2019-02-05 13:23 ` Peter Maydell
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 15/18] iotests: Let verify_platform() check for unsupported platforms Philippe Mathieu-Daudé
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 16/18] iotests: Disable 208 on OpenBSD Philippe Mathieu-Daudé
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 17/18] iotests: Disable 209 " Philippe Mathieu-Daudé
2019-01-29 17:54 ` [Qemu-devel] [RFC PATCH v2 18/18] iotests: Disable 236 and 238 " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e67828c-3f62-da8f-f615-259f721a4bba@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=brad@comstyle.com \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kamil@netbsd.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).