From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:42755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqrEQ-0007aV-OE for qemu-devel@nongnu.org; Mon, 04 Feb 2019 22:17:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqr2e-0000Qe-Ni for qemu-devel@nongnu.org; Mon, 04 Feb 2019 22:04:58 -0500 References: <20190129175403.18017-1-philmd@redhat.com> <20190129175403.18017-3-philmd@redhat.com> <0462853c-2f19-58ff-aee5-d667a86322e1@redhat.com> From: Eric Blake Message-ID: <1e67828c-3f62-da8f-f615-259f721a4bba@redhat.com> Date: Mon, 4 Feb 2019 21:04:30 -0600 MIME-Version: 1.0 In-Reply-To: <0462853c-2f19-58ff-aee5-d667a86322e1@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sXLOWP9kGgGkqMI64bs4nTR4MoA1QfdRC" Subject: Re: [Qemu-devel] [PATCH v2 02/18] configure: Disable W^X on OpenBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Brad Smith , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Max Reitz , Kamil Rytarowski , Stefan Hajnoczi , Paolo Bonzini , Igor Mammedov , Fam Zheng , =?UTF-8?Q?Alex_Benn=c3=a9e?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sXLOWP9kGgGkqMI64bs4nTR4MoA1QfdRC From: Eric Blake To: Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Brad Smith , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Max Reitz , Kamil Rytarowski , Stefan Hajnoczi , Paolo Bonzini , Igor Mammedov , Fam Zheng , =?UTF-8?Q?Alex_Benn=c3=a9e?= Message-ID: <1e67828c-3f62-da8f-f615-259f721a4bba@redhat.com> Subject: Re: [PATCH v2 02/18] configure: Disable W^X on OpenBSD References: <20190129175403.18017-1-philmd@redhat.com> <20190129175403.18017-3-philmd@redhat.com> <0462853c-2f19-58ff-aee5-d667a86322e1@redhat.com> In-Reply-To: <0462853c-2f19-58ff-aee5-d667a86322e1@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/30/19 1:17 AM, Thomas Huth wrote: >> test ... -a ... >> >> is not portable (POSIX permits non-XSI systems to omit support for the= se >> operators, but even where they are supported, there are some inherentl= y >> ambiguous inputs where you CANNOT predict whether the shell will parse= >> -a as a binary operator or as an argument to some other operator). >> Instead, you should ALWAYS break dual tests into: >> >> test ... && test ... >> >> instead. (Same for '-o' vs '|| test') >=20 > $ grep 'test.* -a ' configure | wc -l > 21 > $ grep 'test.* && ' configure | wc -l > 16 >=20 > Looks like we do not really care? Well, I care. Enough to propose a patch :) https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00960.html --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --sXLOWP9kGgGkqMI64bs4nTR4MoA1QfdRC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlxY/T4ACgkQp6FrSiUn Q2rTzAf+L5+nmQmwx2lsMb9fasnP9FR6GGwxeWypycM2AS9qzMSTv6KuIXUN4n4H ovKKrIO+qIdrOa6Agb/xvaAnc0rIhalJzI2EDcStL43bk0j3oLml1i7CqDXjQHmZ FvQtEBnhdODTy06wKrUOD1TH5vdAfZ4nu8neJiTpjCu1ygAoQewBnhE4IZd+ymiR jMN4eHbz+qc/KgLvR7HbVMGBNmOO9ZuUUY1wHCdgXADpus74kwYjZ0XJWjrdJl2G Mu1MznHcpOcWEHkCZupVpD71BiQ2VjCNxxc7vw+xWht7d2wJNtabiZ1UNrRsBA7R S8Qgnk7et/5tFPg2R+PMQUt1zSnKHw== =CCZH -----END PGP SIGNATURE----- --sXLOWP9kGgGkqMI64bs4nTR4MoA1QfdRC--