From: Thomas Huth <thuth@redhat.com>
To: Michele Denber <denber@mindspring.com>
Cc: Peter Tribble <peter.tribble@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] configure / util: Auto-detect the availability of openpty()
Date: Thu, 2 Jul 2020 19:34:53 +0200 [thread overview]
Message-ID: <1e699fdc-639e-ef8a-313f-7e665cad868c@redhat.com> (raw)
In-Reply-To: <5EFE07BC.6040407@mindspring.com>
On 02/07/2020 18.13, Michele Denber wrote:
>
>
> On 07/02/20 10:39, Thomas Huth wrote:
>> Recent versions of Solaris (v11.4) now feature an openpty() function,
>> too, causing a build failure since we ship our own implementation of
>> openpty() for Solaris in util/qemu-openpty.c so far. Since there are
>> now both variants available in the wild, with and without this function,
>> let's introduce a proper HAVE_OPENPTY define for this to fix the build
>> failure.
>>
>> Signed-off-by: Thomas Huth<thuth@redhat.com>
>> ---
>> Note: Untested, since I do not have a VM with Solaris. Michele,
>> Peter, I'd really appreciate a "Tested-by:" from you here. Thanks!
> Sorry, I was off on another project (doing my taxes). Is this patch
> missing something? It looks like there should be more. The last line is
>
> static void cfmakeraw (struct termios *termios_p) {
>
> with no matching "}".
That's just the context, cut at three lines after the last change.
Simply try to apply the patch with "patch -p1 -i ..." or "git am" in a
separate git branch if you're using git. It should hopefully apply cleanly.
Thomas
next prev parent reply other threads:[~2020-07-02 17:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:39 [PATCH] configure / util: Auto-detect the availability of openpty() Thomas Huth
2020-07-02 14:46 ` Daniel P. Berrangé
2020-07-02 16:07 ` Michele Denber
2020-07-02 17:38 ` Thomas Huth
2020-07-02 16:13 ` Michele Denber
2020-07-02 17:34 ` Thomas Huth [this message]
2020-07-02 21:33 ` Michele Denber
2020-07-03 5:11 ` Thomas Huth
2020-07-03 16:25 ` Michele Denber
2020-07-03 16:34 ` Michele Denber
2020-07-03 16:50 ` Peter Maydell
2020-07-03 18:49 ` gmake in Solaris 11.4: _IOR missing Michele Denber
2020-07-03 21:35 ` gmake in Solaris 11.4: TFR missing Michele Denber
2020-07-03 21:55 ` Philippe Mathieu-Daudé
2020-07-04 9:11 ` Peter Maydell
2020-07-04 11:30 ` Philippe Mathieu-Daudé
2020-07-04 13:52 ` Peter Maydell
2020-07-04 15:27 ` Michele Denber
2020-07-04 12:02 ` Thomas Huth
2020-07-04 15:36 ` Michele Denber
2020-07-04 15:57 ` Philippe Mathieu-Daudé
2020-07-04 19:15 ` Michele Denber
2020-07-04 21:58 ` Peter Maydell
2020-07-04 19:48 ` Michele Denber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e699fdc-639e-ef8a-313f-7e665cad868c@redhat.com \
--to=thuth@redhat.com \
--cc=denber@mindspring.com \
--cc=peter.tribble@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).