From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Cleber Rosa <crosa@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v5 13/16] python/machine.py: fix _popen access
Date: Mon, 13 Jul 2020 11:31:35 +0200 [thread overview]
Message-ID: <1e6d2a52-999c-5e55-199c-d50bae6527d8@redhat.com> (raw)
In-Reply-To: <20200710052220.3306-14-jsnow@redhat.com>
On 7/10/20 7:22 AM, John Snow wrote:
> As always, Optional[T] causes problems with unchecked access. Add a
> helper that asserts the pipe is present before we attempt to talk with
> it.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-07-13 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 5:22 [PATCH v5 00/16] python: add mypy support to python/qemu John Snow
2020-07-10 5:22 ` [PATCH v5 01/16] python/qmp.py: Define common types John Snow
2020-07-10 5:22 ` [PATCH v5 02/16] iotests.py: use qemu.qmp type aliases John Snow
2020-07-10 5:22 ` [PATCH v5 03/16] python/qmp.py: re-absorb MonitorResponseError John Snow
2020-07-10 5:22 ` [PATCH v5 04/16] python/qmp.py: Do not return None from cmd_obj John Snow
2020-07-10 5:22 ` [PATCH v5 05/16] python/qmp.py: add casts to JSON deserialization John Snow
2020-07-10 5:22 ` [PATCH v5 06/16] python/qmp.py: add QMPProtocolError John Snow
2020-07-10 5:22 ` [PATCH v5 07/16] python/machine.py: Fix monitor address typing John Snow
2020-07-10 5:22 ` [PATCH v5 08/16] python/machine.py: reorder __init__ John Snow
2020-07-10 5:22 ` [PATCH v5 09/16] python/machine.py: Don't modify state in _base_args() John Snow
2020-07-10 5:22 ` [PATCH v5 10/16] python/machine.py: Handle None events in events_wait John Snow
2020-07-10 5:22 ` [PATCH v5 11/16] python/machine.py: use qmp.command John Snow
2020-07-10 5:22 ` [PATCH v5 12/16] python/machine.py: Add _qmp access shim John Snow
2020-07-13 9:37 ` Philippe Mathieu-Daudé
2020-07-10 5:22 ` [PATCH v5 13/16] python/machine.py: fix _popen access John Snow
2020-07-13 9:31 ` Philippe Mathieu-Daudé [this message]
2020-07-10 5:22 ` [PATCH v5 14/16] python/qemu: make 'args' style arguments immutable John Snow
2020-07-10 5:22 ` [PATCH v5 15/16] iotests.py: Adjust HMP kwargs typing John Snow
2020-07-10 5:22 ` [PATCH v5 16/16] python/qemu: Add mypy type annotations John Snow
2020-07-13 9:36 ` Philippe Mathieu-Daudé
2020-07-14 19:25 ` [PATCH v5 00/16] python: add mypy support to python/qemu Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e6d2a52-999c-5e55-199c-d50bae6527d8@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).