Re: [Qemu-devel] [PATCH v2 for-2.9 02/47] qapi: Make doc comments optional where we don't need them

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On 03/15/2017 10:13 AM, Markus Armbruster wrote:

>>> +Pragma's scope is currently the complete schema.  Setting it to
>>
>> You can do:
>>
>> { 'pragma': { 'doc-required': true } }
>> { 'pragma': { 'whitelist': [...] } }
>>
>> what you can't do is:
>>
>> { 'pragma': { 'doc-required': true } }
>> { 'pragma': { 'doc-required': false } }
>>
>> Maybe s/Setting it/Setting a given pragma name/
> 
> Yes, that's better.  Perhaps "Setting the same pragma to ..."

Works for me.

> 
>>> +different values in parts of the schema doesn't work.
> 
> I considered rejecting all but the first pragma for any given pragma,
> but decided just add this note for now.

Yeah, I noticed. Coding up rejection is harder than just documenting
that repetition is undefined.  And it's not like we're adding new pragma
usages into our *.json files on a daily basis ;)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]