From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [PATCH] target/sparc: Handle FPRS correctly on big-endian hosts
Date: Sun, 16 Jul 2023 18:09:15 +0100 [thread overview]
Message-ID: <1e89e4a8-8268-a46c-21d3-6fcb87ecaf8b@linaro.org> (raw)
In-Reply-To: <20230714172602.397267-1-peter.maydell@linaro.org>
On 7/14/23 18:26, Peter Maydell wrote:
> +++ b/target/sparc/gdbstub.c
> @@ -96,7 +96,10 @@ int sparc_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)
> case 83:
> return gdb_get_regl(mem_buf, env->fsr);
> case 84:
> - return gdb_get_regl(mem_buf, env->fprs);
> + {
> + target_ulong fprs = env->fprs;
> + return gdb_get_regl(mem_buf, fprs);
> + }
Surely no change at all here. The compiler zero-extends uint32_t to target_ulong in the
parameter to gdb_get_regl.
r~
prev parent reply other threads:[~2023-07-16 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 17:26 [PATCH] target/sparc: Handle FPRS correctly on big-endian hosts Peter Maydell
2023-07-14 17:29 ` Peter Maydell
2023-07-14 17:52 ` Philippe Mathieu-Daudé
2023-07-16 17:32 ` Peter Maydell
2023-07-17 11:42 ` Philippe Mathieu-Daudé
2023-07-16 17:09 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e89e4a8-8268-a46c-21d3-6fcb87ecaf8b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).