Re: [RFC PATCH] meson.build: report graphics backends

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi Alex,

On 22/12/23 12:48, Alex Bennée wrote:
> To enable accelerated VirtIO GPUs for the guest we need the rendering
> support on the host but currently it's not reported in the
> configuration summary. Add a graphics backend section and report the
> status of the VirGL and Rutabaga support libraries.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   meson.build | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 6c77d9687de..93868568870 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4307,6 +4307,12 @@ summary_info += {'curses support':    curses}
>   summary_info += {'brlapi support':    brlapi}
>   summary(summary_info, bool_yn: true, section: 'User interface')
>   
> +# Graphics backends
> +summary_info = {}
> +summary_info += {'VirGL support':     virgl}
> +summary_info += {'Rutabaga support':  rutabaga}

These are already under the generic 'Dependencies' section
below.

> +summary(summary_info, bool_yn: true, section: 'Graphics backends')
> +
>   # Audio backends
>   summary_info = {}
>   if targetos not in ['darwin', 'haiku', 'windows']

Instead you want to move to your new section:

-- >8 --
diff --git a/meson.build b/meson.build
index 1bf526d653..ad7d870321 100644
--- a/meson.build
+++ b/meson.build
@@ -4308,4 +4308,11 @@ summary_info += {'brlapi support':    brlapi}
  summary(summary_info, bool_yn: true, section: 'User interface')

+# Graphics backends
+summary_info = {}
+summary_info += {'OpenGL support (epoxy)': opengl}
+summary_info += {'VirGL support': virgl}
+summary_info += {'Rutabaga support': rutabaga}
+summary(summary_info, bool_yn: true, section: 'Graphics backends')
+
  # Audio backends
  summary_info = {}
@@ -4343,6 +4350,4 @@ summary_info += {'libtasn1':          tasn1}
  summary_info += {'PAM':               pam}
  summary_info += {'iconv support':     iconv}
-summary_info += {'virgl support':     virgl}
-summary_info += {'rutabaga support':  rutabaga}
  summary_info += {'blkio support':     blkio}
  summary_info += {'curl support':      curl}
@@ -4361,5 +4366,4 @@ summary_info += {'U2F support':       u2f}
  summary_info += {'libusb':            libusb}
  summary_info += {'usb net redir':     usbredir}
-summary_info += {'OpenGL support (epoxy)': opengl}
  summary_info += {'GBM':               gbm}
  summary_info += {'libiscsi support':  libiscsi}
---

Without duplication:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>