From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djkul-00059P-4a for qemu-devel@nongnu.org; Mon, 21 Aug 2017 07:30:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djkuk-0007rg-70 for qemu-devel@nongnu.org; Mon, 21 Aug 2017 07:30:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41726) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1djkuj-0007qk-Pq for qemu-devel@nongnu.org; Mon, 21 Aug 2017 07:30:37 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B7F0737EE9 for ; Mon, 21 Aug 2017 11:30:34 +0000 (UTC) References: <20170818141512.15205-1-famz@redhat.com> <20170818141512.15205-3-famz@redhat.com> <060c28df-bc84-01da-9c7b-2b47221f5311@redhat.com> <20170821111108.GB4371@lemon> From: Paolo Bonzini Message-ID: <1e943c21-9382-2df7-053e-7de9310d4197@redhat.com> Date: Mon, 21 Aug 2017 13:30:29 +0200 MIME-Version: 1.0 In-Reply-To: <20170821111108.GB4371@lemon> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/3] scsi: Enhance scsi_sense_to_errno List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org On 21/08/2017 13:11, Fam Zheng wrote: > On Fri, 08/18 16:36, Paolo Bonzini wrote: >> On 18/08/2017 16:15, Fam Zheng wrote: >>> Two changes: >>> >>> 1) Look at asc/ascq for NOT_READY and DATA_PROTECT; >>> 2) Translate SPACE_ALLOC_FAILED as ENOSPC; >>> >>> Signed-off-by: Fam Zheng >>> --- >>> util/scsi.c | 7 +++---- >>> 1 file changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/util/scsi.c b/util/scsi.c >>> index 92ca436cd0..d42ce33449 100644 >>> --- a/util/scsi.c >>> +++ b/util/scsi.c >>> @@ -18,13 +18,11 @@ >>> int scsi_sense_to_errno(int key, int asc, int ascq) >>> { >>> switch (key) { >>> - case 0x02: /* SCSI_SENSE_NOT_READY */ >>> - return EBUSY; >>> - case 0x07: /* SCSI_SENSE_DATA_PROTECTION */ >>> - return EACCES; >>> case 0x0b: /* SCSI_SENSE_COMMAND_ABORTED */ >>> return ECANCELED; >>> + case 0x02: /* SCSI_SENSE_NOT_READY */ >>> case 0x05: /* SCSI_SENSE_ILLEGAL_REQUEST */ >>> + case 0x07: /* SCSI_SENSE_DATA_PROTECTION */ >>> /* Parse ASCQ */ >>> break; >>> default: >> >> UNIT_ATTENTION should also be passed down to the guest without stopping >> the VM. Maybe map it to EAGAIN? > > Or just 0? That works too, it depends on how you define 0. 1h is defined as informational only and can be dropped, 0x0401 or UNIT_ATTENTION definitely cannot. Paolo >> >> Looking at what Linux does: >> >> - RECOVERED_ERROR should just return 0 >> >> - 0x0401 is "unit in the process of becoming ready", and it should also >> be EAGAIN >> >> - 0x0402 is "initializing command required", and probably can be fixed >> by the guest by scsi-block but not by iscsi so it should be its own >> errno, maybe ENOTCONN? (iscsi might try sending START STOP UNIT >> followed by a bunch of TEST UNIT READYs, see scsi_eh_try_stu in Linux's >> drivers/scsi/scsi_error.c). > > These makes sense to me. > > Fam >