From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3BC7C4338F for ; Thu, 12 Aug 2021 15:17:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 211AB60EB5 for ; Thu, 12 Aug 2021 15:17:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 211AB60EB5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mECSd-0006wS-WC for qemu-devel@archiver.kernel.org; Thu, 12 Aug 2021 11:17:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mECRG-0005Bd-Ds for qemu-devel@nongnu.org; Thu, 12 Aug 2021 11:16:10 -0400 Received: from 3.mo548.mail-out.ovh.net ([188.165.32.156]:36069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mECRE-0005ok-La for qemu-devel@nongnu.org; Thu, 12 Aug 2021 11:16:10 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.146.131]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 63DF720504; Thu, 12 Aug 2021 15:15:56 +0000 (UTC) Received: from kaod.org (37.59.142.95) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 12 Aug 2021 17:15:55 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-95G001c9455ccc-d02e-4a89-916f-597c1b8e9b1e, F21CE8212BD8F0BC5EECA12F1B7E00F4D5E87F00) smtp.auth=clg@kaod.org X-OVh-ClientIp: 90.89.73.13 Subject: Re: [PATCH 09/10] hw/misc: Add Infineon DPS310 sensor model To: Joel Stanley , Corey Minyard References: <20210809131556.686260-1-clg@kaod.org> <20210809131556.686260-10-clg@kaod.org> <20210810233727.GR3406@minyard.net> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <1e97d2e4-57c6-e88d-88ee-db70bdc85a04@kaod.org> Date: Thu, 12 Aug 2021 17:15:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.95] X-ClientProxiedBy: DAG8EX2.mxp5.local (172.16.2.72) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 80b952c5-1977-47e7-9755-a6023d096d85 X-Ovh-Tracer-Id: 4263782949440162598 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvtddrkeefgdekhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeejkeduueduveelgeduueegkeelffevledujeetffeivdelvdfgkeeufeduheehfeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehjohgvlhesjhhmshdrihgurdgruh Received-SPF: pass client-ip=188.165.32.156; envelope-from=clg@kaod.org; helo=3.mo548.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/11/21 3:25 AM, Joel Stanley wrote: > On Tue, 10 Aug 2021 at 23:37, Corey Minyard wrote: >> >> On Mon, Aug 09, 2021 at 03:15:55PM +0200, Cédric Le Goater wrote: >>> From: Joel Stanley >>> >>> This contains some hardcoded register values that were obtained from the >>> hardware after reading the temperature. >>> >>> It does enough to test the Linux kernel driver. The FIFO mode, IRQs and >>> operation modes other than the default as used by Linux are not modelled. >>> >>> Signed-off-by: Joel Stanley >>> [ clg: Fix sequential reading ] >>> Message-Id: <20210616073358.750472-2-joel@jms.id.au> >>> Signed-off-by: Cédric Le Goater >>> Message-Id: <20210629142336.750058-4-clg@kaod.org> >>> Signed-off-by: Cédric Le Goater >>> --- >>> hw/misc/dps310.c | 227 ++++++++++++++++++++++++++++++++++++++++++++ >> >> Can this go into hw/sensor? > > For sure. I wrote it four years ago, when obviously hw/sensor didn't exist. I moved it under hw/sensor. C.