From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, peter.maydell@linaro.org,
jiaxun.yang@flygoat.com, maobibo@loongson.cn,
pbonzini@redhat.com, armbru@redhat.com, lixianglai@loongson.cn
Subject: Re: [PATCH v2] hw/loongarch/boot: Use warn_report when no kernel filename
Date: Tue, 29 Oct 2024 23:18:17 -0300 [thread overview]
Message-ID: <1eb668d7-50a1-49ab-b94b-752ad68de2e2@linaro.org> (raw)
In-Reply-To: <20241030012359.4040817-1-gaosong@loongson.cn>
On 29/10/24 22:23, Song Gao wrote:
> When we run “qemu-system-loongarch64 -qmp stdio -vnc none -S”,
> we get an error message “Need kernel filename” and then we can't use qmp cmd to query some information.
> So, we just throw a warning and then the cpus starts running from address VIRT_FLASH0_BASE.
>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
> hw/loongarch/boot.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> @@ -286,8 +286,7 @@ static void loongarch_direct_kernel_boot(struct loongarch_boot_info *info)
> kernel_addr = load_kernel_info(info);
> } else {
> if(!qtest_enabled()) {
> - error_report("Need kernel filename\n");
> - exit(1);
> + warn_report("No kernel provided, booting from flash drive. \n");
Stripping trailing " \n",
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> }
> }
>
prev parent reply other threads:[~2024-10-30 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 1:23 [PATCH v2] hw/loongarch/boot: Use warn_report when no kernel filename Song Gao
2024-10-30 2:18 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb668d7-50a1-49ab-b94b-752ad68de2e2@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=lixianglai@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).