qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jones <drjones@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>, kvm-devel <kvm@vger.kernel.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM
Date: Tue, 23 Jun 2020 11:29:50 +0200	[thread overview]
Message-ID: <1ec46d92-ae37-0d78-0a5e-7615d91d36b6@redhat.com> (raw)
In-Reply-To: <CAFEAcA-2-g=ZMMRkxoT-ncxqbdjc5vV1WbFzGXw7R8o7QOb6hQ@mail.gmail.com>

On 6/23/20 11:19 AM, Peter Maydell wrote:
> On Tue, 23 Jun 2020 at 10:18, Andrew Jones <drjones@redhat.com> wrote:
>>
>> On Tue, Jun 23, 2020 at 11:06:20AM +0200, Philippe Mathieu-Daudé wrote:
>>> Since v2:
>>> - include Drew test fix (addressed Peter review comments)
>>> - addressed Drew review comments
>>> - collected R-b/A-b
>>>
>>> Andrew Jones (1):
>>>   tests/qtest/arm-cpu-features: Add feature setting tests
>>>
>>> Philippe Mathieu-Daudé (1):
>>>   target/arm: Check supported KVM features globally (not per vCPU)
>>>
>>>  target/arm/kvm_arm.h           | 21 ++++++++-----------
>>>  target/arm/cpu.c               |  2 +-
>>>  target/arm/cpu64.c             | 10 ++++-----
>>>  target/arm/kvm.c               |  4 ++--
>>>  target/arm/kvm64.c             | 14 +++++--------
>>>  tests/qtest/arm-cpu-features.c | 38 ++++++++++++++++++++++++++++++----
>>>  6 files changed, 56 insertions(+), 33 deletions(-)
>>>
>>> --
>>> 2.21.3
>>>
>>>
>>
>> Hi Phil,
>>
>> Thanks for including the test patch. To avoid breaking bisection, if one
>> were to use qtest to bisect something, then the order of patches should
>> be reversed.

Oops :)

>> I guess Peter can apply them that way without a repost
>> though.
> 
> Yeah, I can just flip the order.

Thanks both!



  reply	other threads:[~2020-06-23  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  9:06 [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM Philippe Mathieu-Daudé
2020-06-23  9:06 ` [PATCH v3 1/2] tests/qtest/arm-cpu-features: Add feature setting tests Philippe Mathieu-Daudé
2020-06-23  9:06 ` [PATCH v3 2/2] target/arm: Check supported KVM features globally (not per vCPU) Philippe Mathieu-Daudé
2020-06-23  9:18 ` [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM Andrew Jones
2020-06-23  9:19   ` Peter Maydell
2020-06-23  9:29     ` Philippe Mathieu-Daudé [this message]
2020-06-23 10:35 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ec46d92-ae37-0d78-0a5e-7615d91d36b6@redhat.com \
    --to=philmd@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).